Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: content/browser/shared_worker/shared_worker_service_impl.h

Issue 2338113002: Revert "Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://c… (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_
6 #define CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_ 6 #define CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 // referenced by active documents. 91 // referenced by active documents.
92 void RenderFrameDetached(int render_process_id, int render_frame_id); 92 void RenderFrameDetached(int render_process_id, int render_frame_id);
93 93
94 // Checks the worker dependency of renderer processes and calls 94 // Checks the worker dependency of renderer processes and calls
95 // IncrementWorkerRefCount and DecrementWorkerRefCount of 95 // IncrementWorkerRefCount and DecrementWorkerRefCount of
96 // RenderProcessHostImpl on UI thread if necessary. 96 // RenderProcessHostImpl on UI thread if necessary.
97 void CheckWorkerDependency(); 97 void CheckWorkerDependency();
98 98
99 void NotifyWorkerDestroyed(int worker_process_id, int worker_route_id); 99 void NotifyWorkerDestroyed(int worker_process_id, int worker_route_id);
100 100
101 // TODO(alokp): Remove after collecting crash data.
102 // Temporary checks to verify that all shared workers are terminated.
103 // It is suspected that shared workers prevent render process hosts
104 // from shutting down: crbug.com/608049
105 void CheckAllWorkersTerminated();
106
107 private: 101 private:
108 class SharedWorkerPendingInstance; 102 class SharedWorkerPendingInstance;
109 class SharedWorkerReserver; 103 class SharedWorkerReserver;
110 104
111 friend struct base::DefaultSingletonTraits<SharedWorkerServiceImpl>; 105 friend struct base::DefaultSingletonTraits<SharedWorkerServiceImpl>;
112 friend class SharedWorkerServiceImplTest; 106 friend class SharedWorkerServiceImplTest;
113 107
114 using UpdateWorkerDependencyFunc = void (*)(const std::vector<int>&, 108 using UpdateWorkerDependencyFunc = void (*)(const std::vector<int>&,
115 const std::vector<int>&); 109 const std::vector<int>&);
116 using TryIncrementWorkerRefCountFunc = bool (*)(bool); 110 using TryIncrementWorkerRefCountFunc = bool (*)(bool);
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 int next_pending_instance_id_; 174 int next_pending_instance_id_;
181 175
182 base::ObserverList<WorkerServiceObserver> observers_; 176 base::ObserverList<WorkerServiceObserver> observers_;
183 177
184 DISALLOW_COPY_AND_ASSIGN(SharedWorkerServiceImpl); 178 DISALLOW_COPY_AND_ASSIGN(SharedWorkerServiceImpl);
185 }; 179 };
186 180
187 } // namespace content 181 } // namespace content
188 182
189 #endif // CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_ 183 #endif // CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/shared_worker/shared_worker_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698