CrOS MD - use vectorized icons for ethernet and VPN.

CrOS MD - use vectorized icons for ethernet and VPN.

Also refactor/limit some functions to make it more obvious how they are
used (and how they are not). For example, previously you could ask for
a VPN or ethernet image for use on the tray, but this never actually
happened. We don't want to add tray icons for these types (particularly
now that they're a different size from the menu icons).

BUG=606817
Committed: https://crrev.com/dce171b5f7d95bebc57c5e25301427cf8270005c
Cr-Commit-Position: refs/heads/master@{#418670}

[Evan Stade, 2016-09-13 23:54:31]

estade@chromium.org changed reviewers:
+ stevenjb@chromium.org, tdanderson@chromium.org

[Evan Stade, 2016-09-13 23:54:32]

https://codereview.chromium.org/2338103002/diff/1/ui/chromeos/network/network...
File ui/chromeos/network/network_icon.cc (left):

https://codereview.chromium.org/2338103002/diff/1/ui/chromeos/network/network...
ui/chromeos/network/network_icon.cc:503: // Note: same as connected image,
shouldn't normally be seen.
AFAICT this comment was wrong, and this code path was being hit. Ironically, the
GetConnectedImage version doesn't have a comment, and it wasn't being hit.

[tdanderson, 2016-09-14 14:10:47]

lgtm

[stevenjb, 2016-09-14 15:49:45]

lgtm

https://codereview.chromium.org/2338103002/diff/20001/ui/chromeos/network/net...
File ui/chromeos/network/network_icon.h (right):

https://codereview.chromium.org/2338103002/diff/20001/ui/chromeos/network/net...
ui/chromeos/network/network_icon.h:43: UI_CHROMEOS_EXPORT gfx::ImageSkia
GetImageForDisconnectedCellNetwork();
s/Cell/Mobile/ since iirc this applies to WiMAX also. I'm trying to recall why
the asymetry here (connected for wifi, disconnected for mobile), maybe comment
where these get used? I guess one can always do a code search.

That said, the only code that calls this is scheduled for deprecation with MD
loign, so it really isn't important.

[Evan Stade, 2016-09-14 19:58:23]

https://codereview.chromium.org/2338103002/diff/20001/ui/chromeos/network/net...
File ui/chromeos/network/network_icon.h (right):

https://codereview.chromium.org/2338103002/diff/20001/ui/chromeos/network/net...
ui/chromeos/network/network_icon.h:43: UI_CHROMEOS_EXPORT gfx::ImageSkia
GetImageForDisconnectedCellNetwork();
On 2016/09/14 15:49:45, stevenjb wrote:
> s/Cell/Mobile/ since iirc this applies to WiMAX also. I'm trying to recall why
> the asymetry here (connected for wifi, disconnected for mobile), maybe comment
> where these get used? I guess one can always do a code search.
> 
> That said, the only code that calls this is scheduled for deprecation with MD
> loign, so it really isn't important.

changed the name, code search should be pretty easy with unique names and few
callsites.

[Evan Stade, 2016-09-14 19:58:28]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-09-14 19:58:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2338103002/#ps40001
(title: "rename Wifi to Mobile")

[commit-bot: I haz the power, 2016-09-14 19:59:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:57:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 20:59:18]

Description was changed from

==========
CrOS MD - use vectorized icons for ethernet and VPN.

Also refactor/limit some functions to make it more obvious how they are
used (and how they are not). For example, previously you could ask for
a VPN or ethernet image for use on the tray, but this never actually
happened. We don't want to add tray icons for these types (particularly
now that they're a different size from the menu icons).

BUG=606817
==========

to

==========
CrOS MD - use vectorized icons for ethernet and VPN.

Also refactor/limit some functions to make it more obvious how they are
used (and how they are not). For example, previously you could ask for
a VPN or ethernet image for use on the tray, but this never actually
happened. We don't want to add tray icons for these types (particularly
now that they're a different size from the menu icons).

BUG=606817

Committed: https://crrev.com/dce171b5f7d95bebc57c5e25301427cf8270005c
Cr-Commit-Position: refs/heads/master@{#418670}
==========

[commit-bot: I haz the power, 2016-09-14 20:59:19]

Patchset 3 (id:??) landed as
https://crrev.com/dce171b5f7d95bebc57c5e25301427cf8270005c
Cr-Commit-Position: refs/heads/master@{#418670}