CrOS MD - use vectorized icons for ethernet and VPN.

ui/chromeos/network/network_icon.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_CHROMEOS_NETWORK_NETWORK_ICON_H_
 #define UI_CHROMEOS_NETWORK_NETWORK_ICON_H_
 
 #include <string>
 
 #include "base/strings/string16.h"
@@ skipping 16 matching lines @@
   ICON_TYPE_LIST,  // dark icons without VPN badges
 };
 
 // Gets the image for the network associated with |service_path|. |network| must
 // not be NULL. |icon_type| determines the color theme and whether or not to
 // show the VPN badge. This caches badged icons per network per |icon_type|.
 UI_CHROMEOS_EXPORT gfx::ImageSkia GetImageForNetwork(
     const chromeos::NetworkState* network,
     IconType icon_type);
 
-// Gets the fulls strength image for a connected network type.
-UI_CHROMEOS_EXPORT gfx::ImageSkia GetImageForConnectedNetwork(
-    IconType icon_type,
-    const std::string& network_type);
+// Gets the fulls strength image for a wifi network.
+// TODO(estade): Expose SignalStrengthImageSource and use that instead.
+UI_CHROMEOS_EXPORT gfx::ImageSkia GetImageForConnectedWifiNetwork();
 
-// Gets the image for a connecting network type.
-UI_CHROMEOS_EXPORT gfx::ImageSkia GetImageForConnectingNetwork(
-    IconType icon_type,
-    const std::string& network_type);
+// Gets the disconnected image for a cell network.
+// TODO(estade): Expose SignalStrengthImageSource and use that instead.
+UI_CHROMEOS_EXPORT gfx::ImageSkia GetImageForDisconnectedCellNetwork();

[stevenjb, 2016/09/14 15:49:45]

s/Cell/Mobile/ since iirc this applies to WiMAX also. I'm trying to recall why
the asymetry here (connected for wifi, disconnected for mobile), maybe comment
where these get used? I guess one can always do a code search.

That said, the only code that calls this is scheduled for deprecation with MD
loign, so it really isn't important.

[Evan Stade, 2016/09/14 19:58:23]

changed the name, code search should be pretty easy with unique names and few
callsites.

 
-// Gets the image for a disconnected network type.
-UI_CHROMEOS_EXPORT gfx::ImageSkia GetImageForDisconnectedNetwork(
-    IconType icon_type,
-    const std::string& network_type);
+// Returns a vpn image suitable for use on a light background.
+UI_CHROMEOS_EXPORT gfx::ImageSkia GetVpnImage();
 
 // Returns the label for |network| based on |icon_type|. |network| can be NULL.
 UI_CHROMEOS_EXPORT base::string16 GetLabelForNetwork(
     const chromeos::NetworkState* network,
     IconType icon_type);
 
 // Updates and returns the appropriate message id if the cellular network
 // is uninitialized.
 UI_CHROMEOS_EXPORT int GetCellularUninitializedMsg();
 
 // Gets the correct icon and label for |icon_type|. Also sets |animating|
 // based on whether or not the icon is animating (i.e. connecting).
 UI_CHROMEOS_EXPORT void GetDefaultNetworkImageAndLabel(IconType icon_type,
                                                        gfx::ImageSkia* image,
                                                        base::string16* label,
                                                        bool* animating);
 
 // Called when the list of networks changes. Retreives the list of networks
 // from the global NetworkStateHandler instance and removes cached entries
 // that are no longer in the list.
 UI_CHROMEOS_EXPORT void PurgeNetworkIconCache();
 
 }  // namespace network_icon
 }  // namespace ui
 
 #endif  // UI_CHROMEOS_NETWORK_NETWORK_ICON_H_