Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: chrome/android/BUILD.gn

Issue 2338093003: Revert of gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/version_assembly/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index d8cd6a250f3ac91b0e21b278e0234e2da2439a0c..4a5067a020fec3f5ec10da98e1b28601d23ca978 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -4,11 +4,10 @@
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
-import("//build/util/process_version.gni")
import("//build_overrides/v8.gni")
import("//chrome/android/chrome_public_apk_tmpl.gni")
import("//chrome/common/features.gni")
-import("//chrome/process_version_rc_template.gni") # For branding_file_path.
+import("//chrome/version.gni")
import("//testing/test.gni")
import("//third_party/icu/config.gni")
import("//third_party/protobuf/proto_library.gni")
@@ -378,10 +377,6 @@
chrome_version_java_file = "$chrome_version_java_dir/org/chromium/chrome/browser/ChromeVersionConstants.java"
process_version("chrome_version_java") {
template_file = "java/ChromeVersionConstants.java.version"
- sources = [
- "//chrome/VERSION",
- branding_file_path,
- ]
output = chrome_version_java_file
extra_args = [
"-e",
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/version_assembly/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698