Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3078)

Unified Diff: chrome/BUILD.gn

Issue 2338093003: Revert of gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/util/version.gni ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index b2e4edf8828570d1332d8b9e3bccb710d66d5b1f..0534fd03c7f9da88b387c1e27819eb9831120f21 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -13,7 +13,7 @@
import("//build/config/win/manifest.gni")
import("//chrome/chrome_repack_locales.gni")
import("//chrome/common/features.gni")
-import("//chrome/process_version_rc_template.gni")
+import("//chrome/version.gni")
import("//third_party/widevine/cdm/widevine.gni")
import("//ui/base/ui_features.gni")
import("//v8/gni/v8.gni")
@@ -1212,14 +1212,16 @@
}
if (is_win) {
- process_version_rc_template("chrome_exe_version") {
+ process_version("chrome_exe_version") {
+ template_file = chrome_version_rc_template
sources = [
"app/chrome_exe.ver",
]
output = "$target_gen_dir/chrome_exe_version.rc"
}
- process_version_rc_template("chrome_dll_version") {
+ process_version("chrome_dll_version") {
+ template_file = chrome_version_rc_template
sources = [
"app/chrome_dll.ver",
]
@@ -1235,14 +1237,16 @@
type = "dll"
}
- process_version_rc_template("nacl64_exe_version") {
+ process_version("nacl64_exe_version") {
+ template_file = chrome_version_rc_template
sources = [
"app/nacl64_exe.ver",
]
output = "$target_gen_dir/nacl64_exe_version.rc"
}
- process_version_rc_template("other_version") {
+ process_version("other_version") {
+ template_file = chrome_version_rc_template
sources = [
"app/other.ver",
]
« no previous file with comments | « build/util/version.gni ('k') | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698