Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html

Issue 2338013007: Adapt to changes in html5 spec related to tfoot (Closed)
Patch Set: Fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html b/third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html
index 38a24130ef91f5536802bfabb2129e965b6f04e8..93f6d4d9b5391e1bbdaf39dbffeabe8517914606 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html
@@ -9,15 +9,13 @@
var t = document.createElement('table');
- // TODO(foolip): Setting caption/tHead/tFoot to null should not throw
tkent 2016/09/14 22:55:41 The comment is still valid for caption and tHead.
rwlbuis 2016/09/15 14:32:33 Done.
- // an exception, it should just remove the old caption/thead/tfoot.
shouldThrow("t.caption = null");
shouldThrow("t.caption = document.body");
shouldThrow("t.tHead = null");
shouldThrow("t.tHead = document.body");
- shouldThrow("t.tFoot = null");
+ shouldNotThrow("t.tFoot = null");
tkent 2016/09/14 22:55:41 We should confirm that t.tFoot is removed from |t|
rwlbuis 2016/09/15 14:32:33 Done.
shouldThrow("t.tFoot = document.body");
shouldThrow("t.insertRow(-2)");

Powered by Google App Engine
This is Rietveld 408576698