Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2338013004: Simplify lifetime management of ValidateClientHelloResultCallback::Result objects (Closed)

Created:
4 years, 3 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify lifetime management of ValidateClientHelloResultCallback::Result objects The lifetimes of ValidateClientHelloResultCallback::Result objects are managed by bare new/delete. These objects are also passed around by pointer which gives no indication as to who is managing the lifetime, and many methods are passed both a pointer to a Result object as w ell as a reference to a sub-object. This CL eliminates these patterns. Migrating from bare pointers to unique_ptr in some quic codepaths. No functional change intended, not flag-protected. Merge internal change: 132359769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -67 lines) Patch
M net/quic/core/crypto/crypto_server_test.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 3 chunks +7 lines, -5 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 17 chunks +37 lines, -29 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 3 chunks +1 line, -4 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/tools/quic/stateless_rejector.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/stateless_rejector.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
4 years, 3 months ago (2016-09-13 20:30:44 UTC) #2
Zhongyi Shi
4 years, 3 months ago (2016-09-13 21:18:44 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698