Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: net/quic/test_tools/crypto_test_utils_test.cc

Issue 2338013004: Simplify lifetime management of ValidateClientHelloResultCallback::Result objects (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/crypto_test_utils.cc ('k') | net/tools/quic/stateless_rejector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/crypto_test_utils_test.cc
diff --git a/net/quic/test_tools/crypto_test_utils_test.cc b/net/quic/test_tools/crypto_test_utils_test.cc
index 52c0759e95057414ff85178fa1424749f2ed34a5..e082b63feff774979f96d4e0683f827f7a65d135 100644
--- a/net/quic/test_tools/crypto_test_utils_test.cc
+++ b/net/quic/test_tools/crypto_test_utils_test.cc
@@ -32,15 +32,15 @@ class ShloVerifier : public ValidateClientHelloResultCallback {
compressed_certs_cache_(compressed_certs_cache) {}
// Verify that the output message is a SHLO.
- void RunImpl(const CryptoHandshakeMessage& chlo,
- const ValidateClientHelloResultCallback::Result& result,
- std::unique_ptr<ProofSource::Details> /* details */) override {
+ void RunImpl(
+ std::unique_ptr<ValidateClientHelloResultCallback::Result> result,
+ std::unique_ptr<ProofSource::Details> /* details */) override {
QuicCryptoNegotiatedParameters params;
string error_details;
DiversificationNonce diversification_nonce;
CryptoHandshakeMessage out;
crypto_config_->ProcessClientHello(
- result, /*reject_only=*/false, /*connection_id=*/1, server_ip_,
+ *result, /*reject_only=*/false, /*connection_id=*/1, server_ip_,
client_addr_, AllSupportedVersions().front(), AllSupportedVersions(),
/*use_stateless_rejects=*/true, /*server_designated_connection_id=*/0,
clock_, QuicRandom::GetInstance(), compressed_certs_cache_, &params,
« no previous file with comments | « net/quic/test_tools/crypto_test_utils.cc ('k') | net/tools/quic/stateless_rejector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698