Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Issue 2337913004: V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. (Closed)

Created:
4 years, 3 months ago by wuchengli
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. When V4L2VideoDecodeAccelerator sends a frame to processor, it uses an extra BindToCurrentLoop. That is not required because the processor is only accessed on the decoder thread. The worse thing is the processed frame may arrive after the processor is destroyed because of the extra hop, which may cause a native crash in V4L2VDA. BUG=645854 BUG=b/29059119 TEST=Run VDA unittest and video_VideoSeek test. Play video. Review-Url: https://codereview.chromium.org/2329913002 Cr-Commit-Position: refs/heads/master@{#417902} (cherry picked from commit cc85d7601e6932050d2a12d3c03ffb8329969e92) Committed: https://chromium.googlesource.com/chromium/src/+/f48a14aa7d0644df279e2bb332959c2a5e15b912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M media/gpu/v4l2_video_decode_accelerator.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wuchengli
4 years, 3 months ago (2016-09-14 08:53:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f48a14aa7d0644df279e2bb332959c2a5e15b912.

Powered by Google App Engine
This is Rietveld 408576698