Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2329913002: V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. (Closed)

Created:
4 years, 3 months ago by wuchengli
Modified:
4 years, 3 months ago
Reviewers:
kcwu
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org, Pawel Osciak
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. When V4L2VideoDecodeAccelerator sends a frame to processor, it uses an extra BindToCurrentLoop. That is not required because the processor is only accessed on the decoder thread. The worse thing is the processed frame may arrive after the processor is destroyed because of the extra hop, which may cause a native crash in V4L2VDA. BUG=645854 BUG=b/29059119 TEST=Run VDA unittest and video_VideoSeek test. Play video. Committed: https://crrev.com/cc85d7601e6932050d2a12d3c03ffb8329969e92 Cr-Commit-Position: refs/heads/master@{#417902}

Patch Set 1 #

Patch Set 2 : V4L2VideoDecodeAccelerator: fix frame returned after processor destroys. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M media/gpu/v4l2_video_decode_accelerator.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
wuchengli
Kuang-che. One line fix. PTAL.
4 years, 3 months ago (2016-09-12 05:25:21 UTC) #2
kcwu
lgtm BTW, |child_task_runner_| in V4L2ImageProcessor needs rename since it is not "child task runner" for ...
4 years, 3 months ago (2016-09-12 08:30:04 UTC) #3
wuchengli
On 2016/09/12 08:30:04, kcwu wrote: > lgtm > > BTW, |child_task_runner_| in V4L2ImageProcessor needs rename ...
4 years, 3 months ago (2016-09-12 08:31:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329913002/20001
4 years, 3 months ago (2016-09-12 08:31:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 09:42:24 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 09:44:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc85d7601e6932050d2a12d3c03ffb8329969e92
Cr-Commit-Position: refs/heads/master@{#417902}

Powered by Google App Engine
This is Rietveld 408576698