Speculatively deflake some web app tests on low-end Lollipop.

Speculatively deflake some web app tests on low-end Lollipop.

This attempts to deflake two tests which flake on the Lollipop low-end
tester.

WebappSplashScreenIconTest#setUp decodes a string into a bitmap, which
is then encoded back into a string. Remove both of these steps so that
the string is directly inserted into WebappDataStorage. This
speculatively deflakes WebappSplashScreenIconTest#testShowSplashScreen,
which has a criteria takes too long timeout.

WebappSplashScreenTest#testUmaWhenSplashHides fails an assert for
a histogram value representing the number of milliseconds that the
splashscreen was shown. On the theory that the slow device is showing
the splash screen for longer, the speculative fix is to check more of
the histogram buckets.

BUG=636633
Committed: https://crrev.com/d19c087b9bfdf76a8af91e2f0a0e791bf2ffcafa
Cr-Commit-Position: refs/heads/master@{#418438}

[dominickn, 2016-09-13 08:30:15]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 08:30:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-09-13 08:31:01]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dominickn, 2016-09-13 08:31:02]

PTAL, thanks!

[commit-bot: I haz the power, 2016-09-13 09:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 09:24:59]

Dry run: This issue passed the CQ dry run.

[gone, 2016-09-13 17:05:12]

lgtm

Huh.  Would be interesting if this works.

https://codereview.chromium.org/2337843003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
(right):

https://codereview.chromium.org/2337843003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java:272:
@VisibleForTesting
updateSplashBlahBlahForTests?

[dominickn, 2016-09-13 23:40:43]

Thanks!

https://codereview.chromium.org/2337843003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
(right):

https://codereview.chromium.org/2337843003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java:272:
@VisibleForTesting
On 2016/09/13 17:05:12, dfalcantara wrote:
> updateSplashBlahBlahForTests?

Done.

[dominickn, 2016-09-13 23:40:47]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-09-13 23:40:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2337843003/#ps20001
(title: "Address nits")

[commit-bot: I haz the power, 2016-09-13 23:41:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:27:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 00:29:50]

Description was changed from

==========
Speculatively deflake some web app tests on low-end Lollipop.

This attempts to deflake two tests which flake on the Lollipop low-end
tester.

WebappSplashScreenIconTest#setUp decodes a string into a bitmap, which
is then encoded back into a string. Remove both of these steps so that
the string is directly inserted into WebappDataStorage. This
speculatively deflakes WebappSplashScreenIconTest#testShowSplashScreen,
which has a criteria takes too long timeout.

WebappSplashScreenTest#testUmaWhenSplashHides fails an assert for
a histogram value representing the number of milliseconds that the
splashscreen was shown. On the theory that the slow device is showing
the splash screen for longer, the speculative fix is to check more of
the histogram buckets.

BUG=636633
==========

to

==========
Speculatively deflake some web app tests on low-end Lollipop.

This attempts to deflake two tests which flake on the Lollipop low-end
tester.

WebappSplashScreenIconTest#setUp decodes a string into a bitmap, which
is then encoded back into a string. Remove both of these steps so that
the string is directly inserted into WebappDataStorage. This
speculatively deflakes WebappSplashScreenIconTest#testShowSplashScreen,
which has a criteria takes too long timeout.

WebappSplashScreenTest#testUmaWhenSplashHides fails an assert for
a histogram value representing the number of milliseconds that the
splashscreen was shown. On the theory that the slow device is showing
the splash screen for longer, the speculative fix is to check more of
the histogram buckets.

BUG=636633

Committed: https://crrev.com/d19c087b9bfdf76a8af91e2f0a0e791bf2ffcafa
Cr-Commit-Position: refs/heads/master@{#418438}
==========

[commit-bot: I haz the power, 2016-09-14 00:29:51]

Patchset 2 (id:??) landed as
https://crrev.com/d19c087b9bfdf76a8af91e2f0a0e791bf2ffcafa
Cr-Commit-Position: refs/heads/master@{#418438}