chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java - Issue 2337843003: Speculatively deflake some web app tests on low-end Lollipop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java

Issue 2337843003: Speculatively deflake some web app tests on low-end Lollipop. (Closed)

Patch Set: Address nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java

index b73691da8ea653a678b53ca3e2c3989c850b1dc4..a9128e5fb438d0ee2e5db4029afe75b9674f8c3d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java

@@ -32,7 +32,7 @@ public class WebappSplashScreenIconTest extends WebappActivityTestBase {

@Override

protected void setUp() throws Exception {

WebappDataStorage.open(getInstrumentation().getTargetContext(), WEBAPP_ID)

- .updateSplashScreenImage(ShortcutHelper.decodeBitmapFromString(TEST_SPLASH_ICON));

+ .updateSplashScreenImageForTests(TEST_SPLASH_ICON);

super.setUp();

startWebappActivity();