Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2337803003: [DevTools] Migrate ProfilesPanel to TreeOutlineInShadow. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate ProfilesPanel to TreeOutlineInShadow. This is a step towards turning all tree outlines into independent web components, removing global styles related to it and allowing more components to encapsulate their inner details. BUG=none Committed: https://crrev.com/e17afc530a565d3d1c66f316750c817af60cb3ff Cr-Commit-Position: refs/heads/master@{#418936}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -75 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 11 chunks +15 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/heapProfiler.css View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css View 1 chunk +0 lines, -32 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css View 1 1 chunk +185 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-13 02:08:54 UTC) #2
pfeldman
https://codereview.chromium.org/2337803003/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css File third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css (right): https://codereview.chromium.org/2337803003/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css#newcode7 third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css:7: :host { We should not have patches this big. ...
4 years, 3 months ago (2016-09-13 17:32:51 UTC) #4
dgozman
https://codereview.chromium.org/2337803003/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css File third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css (right): https://codereview.chromium.org/2337803003/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css#newcode7 third_party/WebKit/Source/devtools/front_end/profiler/profilesSidebarTree.css:7: :host { On 2016/09/13 17:32:51, pfeldman wrote: > We ...
4 years, 3 months ago (2016-09-13 20:06:50 UTC) #5
pfeldman
lgtm
4 years, 3 months ago (2016-09-14 00:24:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337803003/20001
4 years, 3 months ago (2016-09-15 17:49:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 19:51:02 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 19:53:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e17afc530a565d3d1c66f316750c817af60cb3ff
Cr-Commit-Position: refs/heads/master@{#418936}

Powered by Google App Engine
This is Rietveld 408576698