Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2335983002: [DevTools] Remove SidebarTreeElement from ProfilesPanel. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove SidebarTreeElement from ProfilesPanel. This is a step towards removing SidebarTreeElement, and moving all tree outlines into shadow dom. BUG=none Committed: https://crrev.com/40a78688dffd36ab1ace3c9cdc06242425067b19 Cr-Commit-Position: refs/heads/master@{#418708}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -32 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 12 chunks +111 lines, -32 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-13 00:37:18 UTC) #2
alph
lgtm https://codereview.chromium.org/2335983002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js File third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js (right): https://codereview.chromium.org/2335983002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js#newcode1165 third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js:1165: this._titlesElement.classList.remove("no-subtitle"); nit: this._subtitleElement.textContent = statusUpdate.subtitle || ""; this._titlesElement.classList.toggle("no-subtitle", ...
4 years, 3 months ago (2016-09-13 00:59:07 UTC) #3
dgozman
https://codereview.chromium.org/2335983002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js File third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js (right): https://codereview.chromium.org/2335983002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js#newcode1165 third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js:1165: this._titlesElement.classList.remove("no-subtitle"); On 2016/09/13 00:59:07, alph wrote: > nit: > ...
4 years, 3 months ago (2016-09-14 18:34:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335983002/40001
4 years, 3 months ago (2016-09-14 19:11:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/293088)
4 years, 3 months ago (2016-09-14 21:14:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335983002/40001
4 years, 3 months ago (2016-09-14 21:27:31 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-14 22:59:16 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 23:00:56 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40a78688dffd36ab1ace3c9cdc06242425067b19
Cr-Commit-Position: refs/heads/master@{#418708}

Powered by Google App Engine
This is Rietveld 408576698