Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: tests/ImageTest.cpp

Issue 2337803002: Don't copy image buffer when calculating size.
Patch Set: Updating tests. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/image/SkImage_Gpu.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/ImageTest.cpp
diff --git a/tests/ImageTest.cpp b/tests/ImageTest.cpp
index e7de3694df71eae5b1eedc2f4cc57d1f6ad542f7..a3178aec28825f792ca6718b4a4c7b0d4692dc17 100644
--- a/tests/ImageTest.cpp
+++ b/tests/ImageTest.cpp
@@ -914,15 +914,16 @@ DEF_GPUTEST_FOR_RENDERING_CONTEXTS(DeferredTextureImage, reporter, ctxInfo) {
kNone_SkFilterQuality, 1, false },
{ [context] { return create_gpu_image(context); },
{{SkMatrix::I(), kNone_SkFilterQuality, 0}},
- kNone_SkFilterQuality, 1, false },
+ kNone_SkFilterQuality, 1, true },
// Create a texture image in a another GrContext.
+ // ////////////////
{ [testContext, otherContextInfo] {
otherContextInfo.testContext()->makeCurrent();
sk_sp<SkImage> otherContextImage = create_gpu_image(otherContextInfo.grContext());
cblume 2016/10/25 02:51:01 This test is now causing a errors on non-GPU: ../.
bsalomon 2016/10/25 18:27:15 I think this one should still be false, right? If
testContext->makeCurrent();
return otherContextImage;
}, {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
- kNone_SkFilterQuality, 1, false },
+ kNone_SkFilterQuality, 1, true },
// Create an image that is too large to upload.
{ create_image_large, {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
kNone_SkFilterQuality, 1, false },
« no previous file with comments | « src/image/SkImage_Gpu.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698