Don't copy image buffer when calculating size.

tests/ImageTest.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <functional>
 #include <initializer_list>
 #include <vector>
@@ skipping 896 matching lines @@
         { create_image,          {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
           kNone_SkFilterQuality, 1, true },
         { create_codec_image,    {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
           kNone_SkFilterQuality, 1, true },
         { create_data_image,     {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
           kNone_SkFilterQuality, 1, true },
         { create_picture_image,  {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
           kNone_SkFilterQuality, 1, false },
         { [context] { return create_gpu_image(context); },
           {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
-          kNone_SkFilterQuality, 1, false },
+          kNone_SkFilterQuality, 1, true },
         // Create a texture image in a another GrContext.
+        // ////////////////
         { [testContext, otherContextInfo] {
             otherContextInfo.testContext()->makeCurrent();
             sk_sp<SkImage> otherContextImage = create_gpu_image(otherContextInfo.grContext());

[cblume, 2016/10/25 02:51:01]

This test is now causing a errors on non-GPU:
../../tests/ImageTest.cpp:857   Expected image pixels to be the same. At 5,5
0xff000000 != 0xffffffff
I'm looking into it now.

[bsalomon, 2016/10/25 18:27:15]

I think this one should still be false, right? If we call
SkImage::getDeferredTextureImageData on an image that has a texture in Context A
with a proxy for Context B it seems simpler to fail rather than to try to do a
readback. This doesn't seem like a likely scenario for Chrome. If we are doing a
readback with the new code (not sure why that'd be) and it is failing then my
guess is that when we do the readback Context A isn't current so we're trying to
readback a texture ID from Context A in Context B.

             testContext->makeCurrent();
             return otherContextImage;
           }, {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
-        kNone_SkFilterQuality, 1, false },
+        kNone_SkFilterQuality, 1, true },
         // Create an image that is too large to upload.
         { create_image_large,    {{SkMatrix::I(), kNone_SkFilterQuality, 0}},
           kNone_SkFilterQuality, 1, false },
         // Create an image that is too large, but is scaled to an acceptable size.
         { create_image_large, {{SkMatrix::I(), kMedium_SkFilterQuality, 4}},
           kMedium_SkFilterQuality, 16, true},
         // Create an image with multiple low filter qualities, make sure we round up.
         { create_image_large, {{SkMatrix::I(), kNone_SkFilterQuality, 4},
                                {SkMatrix::I(), kMedium_SkFilterQuality, 4}},
           kMedium_SkFilterQuality, 16, true},
@@ skipping 108 matching lines @@
     SkBitmap bm1;
     bm1.allocPixels(SkImageInfo::MakeN32(256, 256, kUnpremul_SkAlphaType));
     bm0.readPixels(bm1.info(), bm1.getPixels(), bm1.rowBytes(), 0, 0);
 
     SkBitmap bm2;
     bm2.allocPixels(SkImageInfo::MakeN32(256, 256, kPremul_SkAlphaType));
     bm1.readPixels(bm2.info(), bm2.getPixels(), bm2.rowBytes(), 0, 0);
 
     REPORTER_ASSERT(reporter, equal(bm0, bm2));
 }