Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2337523003:
[inspector] disallow usage of non public api methods in inspector (Closed)
Description[inspector] disallow usage of non public api methods in inspector
Going forward we may relax this, but it is a conscious decision to be made.
BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
Committed: https://crrev.com/eb9dc6328f35b8ba460873d3c55d63fa0b3bf85e
Cr-Commit-Position: refs/heads/master@{#39362}
Patch Set 1 #
Total comments: 2
Patch Set 2 : addressed comments #
Dependent Patchsets: Messages
Total messages: 23 (13 generated)
Dmitry, please take a look!
Description was changed from ========== [inspector] disallow usage of non public api methods in inspector BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org ========== to ========== [inspector] disallow usage of non public api methods in inspector Going forward, we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org ==========
Description was changed from ========== [inspector] disallow usage of non public api methods in inspector Going forward, we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org ========== to ========== [inspector] disallow usage of non public api methods in inspector Going forward we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org ==========
Thanks! lgtm
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
https://codereview.chromium.org/2337523003/diff/1/src/inspector/DEPS File src/inspector/DEPS (right): https://codereview.chromium.org/2337523003/diff/1/src/inspector/DEPS#newcode2 src/inspector/DEPS:2: "-src" Shouldn't you also add "+src/inspector" ?
Patchset #2 (id:20001) has been deleted
all done, please take another look. https://codereview.chromium.org/2337523003/diff/1/src/inspector/DEPS File src/inspector/DEPS (right): https://codereview.chromium.org/2337523003/diff/1/src/inspector/DEPS#newcode2 src/inspector/DEPS:2: "-src" On 2016/09/12 23:10:58, alph wrote: > Shouldn't you also add "+src/inspector" ? Done.
lgtm
The CQ bit was checked by kozyatinskiy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2337523003/#ps40001 (title: "addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [inspector] disallow usage of non public api methods in inspector Going forward we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org ========== to ========== [inspector] disallow usage of non public api methods in inspector Going forward we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [inspector] disallow usage of non public api methods in inspector Going forward we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org ========== to ========== [inspector] disallow usage of non public api methods in inspector Going forward we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/eb9dc6328f35b8ba460873d3c55d63fa0b3bf85e Cr-Commit-Position: refs/heads/master@{#39362} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/eb9dc6328f35b8ba460873d3c55d63fa0b3bf85e Cr-Commit-Position: refs/heads/master@{#39362} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
