Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2336023002: [inspector] replaced std::snprintf with base::OS::SNPrintf (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
alph, dgozman
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] replaced std::snprintf with base::OS::SNPrintf BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/456cf5e1cdd90ff4c0669a6155f5157cff059b8d Cr-Commit-Position: refs/heads/master@{#39363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/inspector/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M src/inspector/String16.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
kozy
please take a look!
4 years, 3 months ago (2016-09-13 01:38:47 UTC) #1
alph
lgtm
4 years, 3 months ago (2016-09-13 01:49:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336023002/1
4 years, 3 months ago (2016-09-13 02:13:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 02:38:53 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 02:39:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/456cf5e1cdd90ff4c0669a6155f5157cff059b8d
Cr-Commit-Position: refs/heads/master@{#39363}

Powered by Google App Engine
This is Rietveld 408576698