Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2337423002: color: Initialize all members of gfx::ColorSpace (Closed)

Created:
4 years, 3 months ago by ccameron
Modified:
4 years, 3 months ago
Reviewers:
hubbe
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Initialize all members of gfx::ColorSpace TBR=hubbe BUG=646708 Committed: https://crrev.com/693732b2f4134ffd4d62b348b8716bdfde953588 Cr-Commit-Position: refs/heads/master@{#418503}

Patch Set 1 #

Patch Set 2 : don't convert invalid iccs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M ui/gfx/color_space.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/color_space.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/gfx/icc_profile.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337423002/20001
4 years, 3 months ago (2016-09-14 07:13:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 07:17:47 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 07:19:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/693732b2f4134ffd4d62b348b8716bdfde953588
Cr-Commit-Position: refs/heads/master@{#418503}

Powered by Google App Engine
This is Rietveld 408576698