Add error details to ParseCertificate test data.

Add error details to ParseCertificate test data.

BUG=634443
Committed: https://crrev.com/cb1ac1c66d18819f7e76d9b8c00117939612e132
Cr-Commit-Position: refs/heads/master@{#419346}

[eroman, 2016-09-15 00:02:36]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 00:03:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-15 00:03:42]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[mattm, 2016-09-15 01:49:08]

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate.cc (right):

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate.cc:26: "Couldn't read Certificate as
SEQUENCE");
TbsCertificate?

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate_unittest.cc (right):

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate_unittest.cc:39: std::string expected_errors;
nit, but order these the same as in mappings?

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate_unittest.cc:44: {"ERRORS", &expected_errors,
true},
Add /* optional */ comment to these trues

[eroman, 2016-09-16 01:24:47]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2016-09-16 01:24:56]

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate.cc (right):

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate.cc:26: "Couldn't read Certificate as
SEQUENCE");
On 2016/09/15 01:49:07, mattm wrote:
> TbsCertificate?

Done.

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
File net/cert/internal/parse_certificate_unittest.cc (right):

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate_unittest.cc:39: std::string expected_errors;
On 2016/09/15 01:49:07, mattm wrote:
> nit, but order these the same as in mappings?

Done.

https://codereview.chromium.org/2337373003/diff/20001/net/cert/internal/parse...
net/cert/internal/parse_certificate_unittest.cc:44: {"ERRORS", &expected_errors,
true},
On 2016/09/15 01:49:07, mattm wrote:
> Add /* optional */ comment to these trues

Done.

[commit-bot: I haz the power, 2016-09-16 01:25:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 01:31:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 01:31:00]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eroman, 2016-09-16 18:29:30]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 18:30:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 18:45:00]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mattm, 2016-09-16 21:23:34]

lgtm

[eroman, 2016-09-16 22:25:37]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:26:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-16 22:26:25]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2016-09-16 22:26:29]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-09-16 22:26:30]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2337373003/#ps100001
(title: "sigh, git rebase-update added junk file")

[commit-bot: I haz the power, 2016-09-16 22:27:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 00:29:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-17 00:32:14]

Description was changed from

==========
Add error details to ParseCertificate test data.

BUG=634443
==========

to

==========
Add error details to ParseCertificate test data.

BUG=634443

Committed: https://crrev.com/cb1ac1c66d18819f7e76d9b8c00117939612e132
Cr-Commit-Position: refs/heads/master@{#419346}
==========

[commit-bot: I haz the power, 2016-09-17 00:32:15]

Patchset 6 (id:??) landed as
https://crrev.com/cb1ac1c66d18819f7e76d9b8c00117939612e132
Cr-Commit-Position: refs/heads/master@{#419346}