Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2337293002: Sort include entries. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Sort include entries. This CL updates all of the includes to be correctly sorted. A PRESUBMIT warning is added (from chromium) that will warn if the includes are in the wrong order on upload. Committed: https://pdfium.googlesource.com/pdfium/+/2ca2da505ba75cd830539ffc98dfc482fd4daa41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -48 lines) Patch
M PRESUBMIT.py View 2 chunks +166 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/cpdf_type3cache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_apsettings.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_variabletext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/ctypeset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/android/fx_android_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/cfx_folderfontinfo.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/cfx_fontmapper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_print.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_actionhandler.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/cfde_txtedtengine.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fde/cfde_txtedtpage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fde/cfde_txtedtparag.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/fde_xml_imp_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_barcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_caret.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_checkbox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_datetimepicker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_listbox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_monthcalendar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_picturebox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_pushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_scrollbar.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/core/ifwl_form.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/qrcode/BC_QRCodeWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-13 20:14:25 UTC) #3
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-13 20:57:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337293002/1
4 years, 3 months ago (2016-09-14 01:06:29 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 01:10:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/2ca2da505ba75cd830539ffc98dfc482fd4d...

Powered by Google App Engine
This is Rietveld 408576698