Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2337273002: Disable local background equivalence when we have a box shadow due to painting bug. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index 997774bdc9a93ba40f2f01487f16fab6a0751c15..c554c4d0ad536e46a2e8ef5b29c8b899e45ddb96 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -137,6 +137,11 @@ bool LayoutBoxModelObject::hasLocalEquivalentBackground() const
if (style()->hasBorderRadius())
return false;
+ // TODO(flackr): Remove this when box shadows are still painted correctly when painting
+ // into the composited scrolling contents layer. https://crbug.com/646464
+ if (style()->boxShadow())
+ return false;
+
const FillLayer* layer = &(style()->backgroundLayers());
for (; layer; layer = layer->next()) {
if (layer->attachment() == LocalBackgroundAttachment)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698