Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2337273002: Disable local background equivalence when we have a box shadow due to painting bug. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 || (scrollableArea->verticalScrollbar() && scrollableArea->verticalS crollbar()->isCustomScrollbar())) { 130 || (scrollableArea->verticalScrollbar() && scrollableArea->verticalS crollbar()->isCustomScrollbar())) {
131 hasCustomScrollbars = true; 131 hasCustomScrollbars = true;
132 } 132 }
133 } 133 }
134 134
135 // TODO(flackr): We should be able to paint locally attached borders with a border-radius 135 // TODO(flackr): We should be able to paint locally attached borders with a border-radius
136 // but these currently do not paint correctly. https://crbug.com/645949 136 // but these currently do not paint correctly. https://crbug.com/645949
137 if (style()->hasBorderRadius()) 137 if (style()->hasBorderRadius())
138 return false; 138 return false;
139 139
140 // TODO(flackr): Remove this when box shadows are still painted correctly wh en painting
141 // into the composited scrolling contents layer. https://crbug.com/646464
142 if (style()->boxShadow())
143 return false;
144
140 const FillLayer* layer = &(style()->backgroundLayers()); 145 const FillLayer* layer = &(style()->backgroundLayers());
141 for (; layer; layer = layer->next()) { 146 for (; layer; layer = layer->next()) {
142 if (layer->attachment() == LocalBackgroundAttachment) 147 if (layer->attachment() == LocalBackgroundAttachment)
143 continue; 148 continue;
144 149
145 // If the outline draws inside the border, it intends to draw on top of the scroller's background, 150 // If the outline draws inside the border, it intends to draw on top of the scroller's background,
146 // however because it is painted into a layer behind the scrolling conte nts layer we avoid auto 151 // however because it is painted into a layer behind the scrolling conte nts layer we avoid auto
147 // promoting in this case to avoid obscuring the outline. 152 // promoting in this case to avoid obscuring the outline.
148 // TODO(flackr): Outlines should be drawn on top of the scrolling conten ts layer so that 153 // TODO(flackr): Outlines should be drawn on top of the scrolling conten ts layer so that
149 // they cannot be covered up by composited scrolling contents. 154 // they cannot be covered up by composited scrolling contents.
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
1177 if (rootElementStyle->hasBackground()) 1182 if (rootElementStyle->hasBackground())
1178 return false; 1183 return false;
1179 1184
1180 if (node() != document().firstBodyElement()) 1185 if (node() != document().firstBodyElement())
1181 return false; 1186 return false;
1182 1187
1183 return true; 1188 return true;
1184 } 1189 }
1185 1190
1186 } // namespace blink 1191 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698