[Cronet] Fix up javadocs for EffectiveConnectionType

[Cronet] Fix up javadocs for EffectiveConnectionType

1. Modify Cpp-to-Java enum generator to allow enum comments
2. Remove EffectiveConnectionType from javadoc classpath, as this is redundant
   with it already being part of the input sources.
3. @hide EffectiveConnectionType as it's experimental

BUG=629299
R=xunjieli

[pauljensen, 2016-09-13 18:43:58]

Helen, PTAL, this is the second CL in the break-up.

[xunjieli, 2016-09-13 21:04:42]

xunjieli@chromium.org changed reviewers:
+ agrieve@chromium.org

[xunjieli, 2016-09-13 21:04:43]

I am slightly concerned about having "{@link},"{@hide}," etc. in CC files, but I
don't see a way around it, so LGTM.

+ agrieve for
build/android/gyp/java_cpp_enum.py &
build/android/gyp/java_cpp_enum_tests.py

[agrieve, 2016-09-14 00:43:45]

https://codereview.chromium.org/2337233003/diff/1/build/android/gyp/java_cpp_...
File build/android/gyp/java_cpp_enum.py (right):

https://codereview.chromium.org/2337233003/diff/1/build/android/gyp/java_cpp_...
build/android/gyp/java_cpp_enum.py:329: /** @hide */
Should @hide really be added unconditionally here?

[pauljensen, 2016-09-14 18:01:14]

https://codereview.chromium.org/2337233003/diff/1/build/android/gyp/java_cpp_...
File build/android/gyp/java_cpp_enum.py (right):

https://codereview.chromium.org/2337233003/diff/1/build/android/gyp/java_cpp_...
build/android/gyp/java_cpp_enum.py:329: /** @hide */
On 2016/09/14 00:43:45, agrieve wrote:
> Should @hide really be added unconditionally here?

The alternative would be to add a comment describing the @IntDef annotation.  I
figured for now hiding it was fine; this is what we do for all other @IntDef
annotations in Cronet.  It can still be used in chromium, it just won't appear
in javadocs.

[agrieve, 2016-09-14 19:04:44]

build lgtm

https://codereview.chromium.org/2337233003/diff/1/build/android/gyp/java_cpp_...
File build/android/gyp/java_cpp_enum.py (right):

https://codereview.chromium.org/2337233003/diff/1/build/android/gyp/java_cpp_...
build/android/gyp/java_cpp_enum.py:329: /** @hide */
On 2016/09/14 18:01:13, pauljensen wrote:
> On 2016/09/14 00:43:45, agrieve wrote:
> > Should @hide really be added unconditionally here?
> 
> The alternative would be to add a comment describing the @IntDef annotation. 
I
> figured for now hiding it was fine; this is what we do for all other @IntDef
> annotations in Cronet.  It can still be used in chromium, it just won't appear
> in javadocs.

Sounds good then. I think likely cronet is the only user of this atm, so we can
always revisit if we want later. I also recently learned that with .aar files,
some support libraries bundle in an "annotations.xml" that contain @IntDef
information, so that's probably the correct longer-term approach.

[pauljensen, 2016-09-15 01:24:31]

On 2016/09/14 19:04:44, agrieve wrote:
> build lgtm
> 
>
https://codereview.chromium.org/2337233003/diff/1/build/android/gyp/java_cpp_...
> File build/android/gyp/java_cpp_enum.py (right):
> 
>
https://codereview.chromium.org/2337233003/diff/1/build/android/gyp/java_cpp_...
> build/android/gyp/java_cpp_enum.py:329: /** @hide */
> On 2016/09/14 18:01:13, pauljensen wrote:
> > On 2016/09/14 00:43:45, agrieve wrote:
> > > Should @hide really be added unconditionally here?
> > 
> > The alternative would be to add a comment describing the @IntDef annotation.

> I
> > figured for now hiding it was fine; this is what we do for all other @IntDef
> > annotations in Cronet.  It can still be used in chromium, it just won't
appear
> > in javadocs.
> 
> Sounds good then. I think likely cronet is the only user of this atm, so we
can
> always revisit if we want later. I also recently learned that with .aar files,
> some support libraries bundle in an "annotations.xml" that contain @IntDef
> information, so that's probably the correct longer-term approach.

Ya, @IntDef is only kept in AAR files, not JAR files.  Cronet will soon be
shipping in AAR files ala crbug.com/629304.  I'll see if the @IntDef stuff needs
to be unhidden to work soon.

[pauljensen, 2016-09-15 01:25:46]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-09-15 01:26:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 02:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 02:44:19]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pauljensen, 2016-09-30 20:48:54]

I'm abandoning this CL.  It's not needed anymore, and I don't want to encourage
javadoced APIs dependent on implementations.