[Cronet] Strip prefix of EFFECTIVE_CONNECTION_TYPE to just TYPE_blah

[Cronet] Strip prefix of EFFECTIVE_CONNECTION_TYPE to just TYPE_blah

The prefix is redundant with the class name. TYPE_ cannot be stripped
because the members like "2G" wouldn't be a proper identifier.

BUG=629299
R=xunjieli

Committed: https://crrev.com/219a575e5ae175db9455939c94040b575e79bf3d
Cr-Commit-Position: refs/heads/master@{#418452}

[pauljensen, 2016-09-13 18:37:41]

Helen, PTAL.  This is the first CL of the break-up.

[xunjieli, 2016-09-13 20:53:25]

xunjieli@chromium.org changed reviewers:
+ tbansal@chromium.org

[xunjieli, 2016-09-13 20:53:25]

+ tbansal: Tarun please confirm this is okay.
LGTM

[pauljensen, 2016-09-13 20:56:56]

Actually, how about I change 2G to MOBILE_2G and then I can get rid of the
redundant TYPE?

[tbansal1, 2016-09-13 21:14:33]

On 2016/09/13 20:56:56, pauljensen wrote:
> Actually, how about I change 2G to MOBILE_2G and then I can get rid of the
> redundant TYPE?

lgtm. But can we keep Type2G. It is redundant but it matches the names
everywhere else (browser code, blink code).

[pauljensen, 2016-09-13 22:03:40]

On 2016/09/13 21:14:33, tbansal1 wrote:
> On 2016/09/13 20:56:56, pauljensen wrote:
> > Actually, how about I change 2G to MOBILE_2G and then I can get rid of the
> > redundant TYPE?
> 
> lgtm. But can we keep Type2G. It is redundant but it matches the names
> everywhere else (browser code, blink code).

Sure.  I'll land it as is then.

[pauljensen, 2016-09-13 22:04:53]

On 2016/09/13 22:03:40, pauljensen wrote:
> On 2016/09/13 21:14:33, tbansal1 wrote:
> > On 2016/09/13 20:56:56, pauljensen wrote:
> > > Actually, how about I change 2G to MOBILE_2G and then I can get rid of the
> > > redundant TYPE?
> > 
> > lgtm. But can we keep Type2G. It is redundant but it matches the names
> > everywhere else (browser code, blink code).
> 
> Sure.  I'll land it as is then.

Well once I fix the build failure :)

[tbansal1, 2016-09-13 23:17:58]

On 2016/09/13 22:04:53, pauljensen wrote:
> On 2016/09/13 22:03:40, pauljensen wrote:
> > On 2016/09/13 21:14:33, tbansal1 wrote:
> > > On 2016/09/13 20:56:56, pauljensen wrote:
> > > > Actually, how about I change 2G to MOBILE_2G and then I can get rid of
the
> > > > redundant TYPE?
> > > 
> > > lgtm. But can we keep Type2G. It is redundant but it matches the names
> > > everywhere else (browser code, blink code).
> > 
> > Sure.  I'll land it as is then.
> 
> Well once I fix the build failure :)

Thanks for doing this.

[pauljensen, 2016-09-14 00:15:25]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2016-09-14 00:15:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org, tbansal@chromium.org
Link to the patchset: https://codereview.chromium.org/2341443002/#ps40001
(title: "fix tests")

[commit-bot: I haz the power, 2016-09-14 00:15:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:46:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 01:50:24]

Description was changed from

==========
[Cronet] Strip prefix of EFFECTIVE_CONNECTION_TYPE to just TYPE_blah

The prefix is redundant with the class name. TYPE_ cannot be stripped
because the members like "2G" wouldn't be a proper identifier.

BUG=629299
R=xunjieli
==========

to

==========
[Cronet] Strip prefix of EFFECTIVE_CONNECTION_TYPE to just TYPE_blah

The prefix is redundant with the class name. TYPE_ cannot be stripped
because the members like "2G" wouldn't be a proper identifier.

BUG=629299
R=xunjieli

Committed: https://crrev.com/219a575e5ae175db9455939c94040b575e79bf3d
Cr-Commit-Position: refs/heads/master@{#418452}
==========

[commit-bot: I haz the power, 2016-09-14 01:50:25]

Patchset 3 (id:??) landed as
https://crrev.com/219a575e5ae175db9455939c94040b575e79bf3d
Cr-Commit-Position: refs/heads/master@{#418452}