Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2337153002: Turn deps of chromium_builder_perf into data_deps. (Closed)

Created:
4 years, 3 months ago by uzer
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn deps of chromium_builder_perf into data_deps. It seems that for "group" labels GN does not include data of dependencies declared as "deps", but it would be convenient if we could refer to chromium_builder_perf group to query all the runtime dependencies of the test binaries. This change does not touch dependency logic, though: all the prerequisites of chromium_builder_perf continue to build as before. The runtime_deps of this target can then be used, e.g., to make archive with all the files required to run all (telemetry-based and binary) performance tests. R=jochen,thakis Committed: https://crrev.com/6b70624056f67731dab77c59ac38e68e05958752 Cr-Commit-Position: refs/heads/master@{#418805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
uzer
Please take a look
4 years, 3 months ago (2016-09-13 15:15:39 UTC) #1
jochen (gone - plz use gerrit)
Dirk is a better reviewer for this
4 years, 3 months ago (2016-09-14 08:25:06 UTC) #3
Dirk Pranke
lgtm.
4 years, 3 months ago (2016-09-14 17:11:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337153002/1
4 years, 3 months ago (2016-09-15 07:20:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 08:14:44 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 08:16:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b70624056f67731dab77c59ac38e68e05958752
Cr-Commit-Position: refs/heads/master@{#418805}

Powered by Google App Engine
This is Rietveld 408576698