Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: BUILD.gn

Issue 2337153002: Turn deps of chromium_builder_perf into data_deps. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 01af6ccf08cc39ec1062a06a492331c19d575255..93ed4e2a3e50cbc864d5ddfb74757b4ec20ce598 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -928,7 +928,7 @@ group("chromium_builder_perf") {
testonly = true
if (!is_ios && !is_android && !is_chromecast) {
- deps = [
+ data_deps = [
"//cc:cc_perftests",
"//chrome/test:load_library_perf_tests",
"//gpu:gpu_perftests",
@@ -937,28 +937,28 @@ group("chromium_builder_perf") {
]
if (!is_chromeos) {
- deps += [ "//chrome/test:performance_browser_tests" ]
+ data_deps += [ "//chrome/test:performance_browser_tests" ]
}
if (is_linux && !is_chromeos) {
if (is_official_build) {
# In GN builds, this is controlled by the 'linux_dump_symbols'
# flag, which defaults to 1 for official builds. For now,
# we skip the separate flag and just key off of is_official_build.
- deps += [ "//chrome:linux_symbols" ]
+ data_deps += [ "//chrome:linux_symbols" ]
}
if (!is_chromeos) {
- deps += [ "//tools/perf/clear_system_cache" ]
+ data_deps += [ "//tools/perf/clear_system_cache" ]
}
}
if (is_win) {
- deps += [
+ data_deps += [
"//chrome/installer/mini_installer:mini_installer",
"//third_party/angle/src/tests:angle_perftests",
]
} else {
- deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
+ data_deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698