Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2337053002: Fix a comment: ALLOW_UNUSED_LOCAL() is not needed for replacing ASSERT_UNUSED() (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a comment: ALLOW_UNUSED_LOCAL() is not needed for replacing ASSERT_UNUSED() From review comments: https://codereview.chromium.org/2327643003/diff/40001/third_party/WebKit/Source/core/fetch/Resource.cpp#newcode754 BUG=596760 Committed: https://crrev.com/a115f803fe701b0039de012617c298f588839581 Cr-Commit-Position: refs/heads/master@{#418268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/wtf/Assertions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
hiroshige
PTAL.
4 years, 3 months ago (2016-09-13 09:37:21 UTC) #3
tkent
lgtm
4 years, 3 months ago (2016-09-13 16:19:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337053002/1
4 years, 3 months ago (2016-09-13 16:19:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 16:24:10 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 16:25:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a115f803fe701b0039de012617c298f588839581
Cr-Commit-Position: refs/heads/master@{#418268}

Powered by Google App Engine
This is Rietveld 408576698