Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: third_party/WebKit/Source/wtf/Assertions.h

Issue 2337053002: Fix a comment: ALLOW_UNUSED_LOCAL() is not needed for replacing ASSERT_UNUSED() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 #else 172 #else
173 #define NO_RETURN_DUE_TO_CRASH 173 #define NO_RETURN_DUE_TO_CRASH
174 #endif 174 #endif
175 175
176 // ASSERT, ASSERT_NOT_REACHED, ASSERT_UNUSED 176 // ASSERT, ASSERT_NOT_REACHED, ASSERT_UNUSED
177 // These macros are compiled out of release builds. 177 // These macros are compiled out of release builds.
178 // Expressions inside them are evaluated in debug builds only. 178 // Expressions inside them are evaluated in debug builds only.
179 // They are deprecated. We should use: 179 // They are deprecated. We should use:
180 // - DCHECK() for ASSERT() 180 // - DCHECK() for ASSERT()
181 // - NOTREACHED() for ASSERT_NOT_REACHED() 181 // - NOTREACHED() for ASSERT_NOT_REACHED()
182 // - DCHECK() and ALLOW_UNUSED_LOCAL() for ASSERT_UNUSED(). 182 // - DCHECK() for ASSERT_UNUSED().
183 #if OS(WIN) 183 #if OS(WIN)
184 // FIXME: Change to use something other than ASSERT to avoid this conflict with 184 // FIXME: Change to use something other than ASSERT to avoid this conflict with
185 // the underlying platform. 185 // the underlying platform.
186 #undef ASSERT 186 #undef ASSERT
187 #endif 187 #endif
188 188
189 #define DCHECK_AT(assertion, file, line) LAZY_STREAM(logging::LogMessage(file, l ine, #assertion).stream(), DCHECK_IS_ON() ? !(assertion) : false) 189 #define DCHECK_AT(assertion, file, line) LAZY_STREAM(logging::LogMessage(file, l ine, #assertion).stream(), DCHECK_IS_ON() ? !(assertion) : false)
190 190
191 #if ENABLE(ASSERT) 191 #if ENABLE(ASSERT)
192 192
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 } \ 302 } \
303 inline const thisType& to##thisType(const argumentType& argumentName) \ 303 inline const thisType& to##thisType(const argumentType& argumentName) \
304 { \ 304 { \
305 ASSERT_WITH_SECURITY_IMPLICATION(referencePredicate); \ 305 ASSERT_WITH_SECURITY_IMPLICATION(referencePredicate); \
306 return static_cast<const thisType&>(argumentName); \ 306 return static_cast<const thisType&>(argumentName); \
307 } \ 307 } \
308 void to##thisType(const thisType*); \ 308 void to##thisType(const thisType*); \
309 void to##thisType(const thisType&) 309 void to##thisType(const thisType&)
310 310
311 #endif // WTF_Assertions_h 311 #endif // WTF_Assertions_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698