Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2336973005: [Offline Pages] Removes the unused "HasPages" function. (Closed)

Created:
4 years, 3 months ago by dewittj
Modified:
4 years, 3 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Removes the unused "HasPages" function. This is part of a cleanup before switching to a query interface. BUG=622763 Committed: https://crrev.com/ed3f594eb4755ca8818de9b1e015f6caab5656b1 Cr-Commit-Position: refs/heads/master@{#418577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -87 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M components/offline_pages/offline_page_model.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M components/offline_pages/offline_page_model_impl_unittest.cc View 4 chunks +7 lines, -11 lines 0 comments Download
M components/offline_pages/stub_offline_page_model.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/offline_pages/stub_offline_page_model.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dewittj
ptal, thanks
4 years, 3 months ago (2016-09-14 14:30:48 UTC) #7
fgorski
lgtm
4 years, 3 months ago (2016-09-14 16:05:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336973005/1
4 years, 3 months ago (2016-09-14 16:07:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 16:12:09 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 16:15:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed3f594eb4755ca8818de9b1e015f6caab5656b1
Cr-Commit-Position: refs/heads/master@{#418577}

Powered by Google App Engine
This is Rietveld 408576698