Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3078)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 2336973005: [Offline Pages] Removes the unused "HasPages" function. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index 5cd61ffb8e5d20bc23fa453b53bec984544f25a9..ed2f1962d494f2caed5f7525d038ccef5257d013 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -170,21 +170,11 @@ public class OfflinePageBridge {
* @param callback The callback to run when the operation completes.
*/
@VisibleForTesting
- public void getAllPages(final Callback<List<OfflinePageItem>> callback) {
+ void getAllPages(final Callback<List<OfflinePageItem>> callback) {
List<OfflinePageItem> result = new ArrayList<>();
nativeGetAllPages(mNativeOfflinePageBridge, result, callback);
}
- /**
- * Returns via callback whether we have any offline pages at all.
- *
- * TODO(dewittj): Remove @VisibleForTesting when this method is called in mainline Chrome.
- */
- @VisibleForTesting
- public void hasPages(final String namespace, final Callback<Boolean> callback) {
- nativeHasPages(mNativeOfflinePageBridge, namespace, callback);
- }
-
/** @return A list of all offline ids that match a particular (namespace, client_id) pair. */
Set<Long> getOfflineIdsForClientId(ClientId clientId) {
assert mIsNativeOfflinePageModelLoaded;
@@ -587,8 +577,6 @@ public class OfflinePageBridge {
final Callback<List<OfflinePageItem>> callback);
private native void nativeCheckPagesExistOffline(long nativeOfflinePageBridge, Object[] urls,
CheckPagesExistOfflineCallbackInternal callback);
- native void nativeHasPages(
- long nativeOfflinePageBridge, String nameSpace, final Callback<Boolean> callback);
@VisibleForTesting
native long[] nativeGetOfflineIdsForClientId(
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698