|
|
Created:
4 years, 3 months ago by Hannes Payer (out of office) Modified:
4 years, 3 months ago Reviewers:
ulan CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Always use the passed-in collector in CollectGarbage.
Do not overwrite a collector decision.
BUG=
Committed: https://crrev.com/c19abaddafb5ede5e0d5efbe608b7fc5d7c7fcd0
Cr-Commit-Position: refs/heads/master@{#39585}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hpayer@chromium.org changed reviewers: + ulan@chromium.org
Description was changed from ========== [heap] Always use the passed in collector in CollectGarbage. BUG= ========== to ========== [heap] Always use the passed-in collector in CollectGarbage. Do not overwrite a collector decision. BUG= ==========
lgtm!
The CQ bit was unchecked by hpayer@chromium.org
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12580) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [heap] Always use the passed-in collector in CollectGarbage. Do not overwrite a collector decision. BUG= ========== to ========== [heap] Always use the passed-in collector in CollectGarbage. Do not overwrite a collector decision. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [heap] Always use the passed-in collector in CollectGarbage. Do not overwrite a collector decision. BUG= ========== to ========== [heap] Always use the passed-in collector in CollectGarbage. Do not overwrite a collector decision. BUG= Committed: https://crrev.com/c19abaddafb5ede5e0d5efbe608b7fc5d7c7fcd0 Cr-Commit-Position: refs/heads/master@{#39585} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c19abaddafb5ede5e0d5efbe608b7fc5d7c7fcd0 Cr-Commit-Position: refs/heads/master@{#39585}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2369933004/ by hpayer@chromium.org. The reason for reverting is: Regresses jank and memory. Revert for offline analysis.. |