Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2336943003: [heap] Always use the passed-in collector in CollectGarbage. (Closed)

Created:
4 years, 3 months ago by Hannes Payer (out of office)
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Always use the passed-in collector in CollectGarbage. Do not overwrite a collector decision. BUG= Committed: https://crrev.com/c19abaddafb5ede5e0d5efbe608b7fc5d7c7fcd0 Cr-Commit-Position: refs/heads/master@{#39585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Hannes Payer (out of office)
4 years, 3 months ago (2016-09-13 13:53:29 UTC) #4
ulan
lgtm!
4 years, 3 months ago (2016-09-13 13:55:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336943003/1
4 years, 3 months ago (2016-09-13 13:57:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12580) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-13 14:51:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336943003/1
4 years, 3 months ago (2016-09-21 09:20:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 09:56:26 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c19abaddafb5ede5e0d5efbe608b7fc5d7c7fcd0 Cr-Commit-Position: refs/heads/master@{#39585}
4 years, 3 months ago (2016-09-21 09:57:16 UTC) #17
Hannes Payer (out of office)
4 years, 2 months ago (2016-09-27 12:40:54 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2369933004/ by hpayer@chromium.org.

The reason for reverting is: Regresses jank and memory. Revert for offline
analysis..

Powered by Google App Engine
This is Rietveld 408576698