Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Issue 2336943002: DevTools: Simplify debug and release mode builds (Closed)

Created:
4 years, 3 months ago by chenwilliam
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Simplify debug and release mode builds Splits build_applications.py into build_debug_applications.py and build_release_applications.py I simplified devtools BUILD.gn by symlinking/copying all of the source code files & folders vs. previously images, acorn, etc files were copied specifically. Addresses refactoring suggestion from release mode CL comment: https://crrev.com/2262743002/ BUG=none Committed: https://crrev.com/2db76b7dc6bf18e3c1d17936137fb02936611aec Cr-Commit-Position: refs/heads/master@{#419022}

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 2

Patch Set 3 : fix copyright year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -387 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 5 chunks +3 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/build_applications.py View 1 chunk +0 lines, -40 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/build_debug_applications.py View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/scripts/build_release_applications.py View 1 2 6 chunks +32 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/devtools/scripts/concatenate_application_code.py View 1 chunk +0 lines, -247 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
chenwilliam
PTAL. Will address other refactoring comments in separate CL.
4 years, 3 months ago (2016-09-13 18:09:54 UTC) #3
pfeldman
https://codereview.chromium.org/2336943002/diff/20001/third_party/WebKit/Source/devtools/BUILD.gn File third_party/WebKit/Source/devtools/BUILD.gn (left): https://codereview.chromium.org/2336943002/diff/20001/third_party/WebKit/Source/devtools/BUILD.gn#oldcode1125 third_party/WebKit/Source/devtools/BUILD.gn:1125: copy("copy_runtime_core") { Where did these go?
4 years, 3 months ago (2016-09-14 00:22:16 UTC) #4
chenwilliam
Please see comment. Also updated copyright years (remembered from your comment in other CL). https://codereview.chromium.org/2336943002/diff/20001/third_party/WebKit/Source/devtools/BUILD.gn ...
4 years, 3 months ago (2016-09-14 01:07:53 UTC) #5
pfeldman
lgtm
4 years, 3 months ago (2016-09-15 21:00:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336943002/40001
4 years, 3 months ago (2016-09-15 21:28:41 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 22:46:06 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 22:47:39 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2db76b7dc6bf18e3c1d17936137fb02936611aec
Cr-Commit-Position: refs/heads/master@{#419022}

Powered by Google App Engine
This is Rietveld 408576698