DevTools: Simplify debug and release mode builds

third_party/WebKit/Source/devtools/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//third_party/WebKit/Source/core/core.gni")
 
 devtools_embedder_scripts = [
   "front_end/devtools.js",
   "front_end/Tests.js",
@@ skipping 1018 matching lines @@
     "$resources_out_dir/InspectorBackendCommands.js",
   ]
 
   args = rebase_path(inputs, root_build_dir) + [
            "--output_js_dir",
            rebase_path(resources_out_dir, root_build_dir),
          ]
 }
 
 action("build_release_devtools") {
-  script = "scripts/build_applications.py"
+  script = "scripts/build_release_applications.py"
 
   deps = [
     ":frontend_protocol_sources",
     ":supported_css_properties",
   ]
 
   helper_scripts = [
     "scripts/modular_build.py",
-    "scripts/concatenate_application_code.py",
     "scripts/rjsmin.py",
   ]
 
   inputs = helper_scripts + all_devtools_files + generated_scripts + [
              "front_end/inspector.html",
              "front_end/toolbox.html",
            ]
 
   outputs = generated_entry_files + generated_workers +
             generated_bundled_modules + generated_remote_modules
@@ skipping 12 matching lines @@
     rebase_path(resources_out_dir, root_build_dir),
     "--debug",
     debug_mode,
   ]
 }
 
 if (debug_devtools) {
   resources_out_debug_dir = "$root_out_dir/resources/inspector/debug"
 
   action("build_debug_devtools") {
-    script = "scripts/build_applications.py"
+    script = "scripts/build_debug_applications.py"
 
     deps = [
-      ":copy_debug_files",
+      ":copy_generated_scripts",
     ]
 
     inputs = all_devtools_files + [
                "front_end/inspector.html",
                "front_end/toolbox.html",
              ]
 
     outputs = [
       "$resources_out_debug_dir/inspector.html",
       "$resources_out_debug_dir/toolbox.html",
     ]
 
     debug_mode = "1"
 
     args = [
       "inspector",
       "toolbox",
       "formatter_worker",
       "heap_snapshot_worker",
       "temp_storage_shared_worker",
       "--input_path",
       rebase_path("front_end", root_build_dir),
       "--output_path",
       rebase_path(resources_out_debug_dir, root_build_dir),
       "--debug",
       debug_mode,
     ]
   }
 
-  group("copy_debug_files") {
-    public_deps = [
-      ":copy_acorn_js_files",
-      ":copy_codemirror_files",
-      ":copy_emulated_devices_images_debug",
-      ":copy_generated_scripts",
-      ":copy_inspector_images_debug",
-      ":copy_runtime_core",
-    ]
-  }
-
-  copy("copy_runtime_core") {

[pfeldman, 2016/09/14 00:22:15]

Where did these go?

[chenwilliam, 2016/09/14 01:07:53]

In the DebugBuilder, rather than parsing through the list of modules in the
application json to copy/symlink them, I iterate through all the files and
folders in front_end and symlink/copy them. This way we don't need to manually
specify these non-module files to copy in gn, but we still get all the files we
need for debug mode.

-    sources = devtools_core_base_files
-    outputs = [
-      "$resources_out_debug_dir/{{source_file_part}}",
-    ]
-  }
-
-  copy("copy_acorn_js_files") {
-    sources = devtools_acorn_files
-    outputs = [
-      "$resources_out_debug_dir/acorn/{{source_file_part}}",
-    ]
-  }
-
-  copy("copy_codemirror_files") {
-    sources = devtools_cm_js_files + devtools_cm_css_files
-    outputs = [
-      "$resources_out_debug_dir/cm/{{source_file_part}}",
-    ]
-  }
-
   copy("copy_generated_scripts") {
     deps = [
       ":frontend_protocol_sources",
       ":supported_css_properties",
     ]
     sources = generated_scripts
     outputs = [
       "$resources_out_debug_dir/{{source_file_part}}",
     ]
   }
-  copy("copy_inspector_images_debug") {
-    sources = devtools_image_files
-    outputs = [
-      "$resources_out_debug_dir/Images/{{source_file_part}}",
-    ]
-  }
-
-  copy("copy_emulated_devices_images_debug") {
-    sources = devtools_emulated_devices_images
-    outputs = [
-      "$resources_out_debug_dir/emulated_devices/{{source_file_part}}",
-    ]
-  }
 }