Issue 2336903003: Stop using chromium_builder_tests target in NaCl SDK build

Issue 2336903003: Stop using chromium_builder_tests target in NaCl SDK build (Closed)

Created:
4 years, 3 months ago by Sam Clegg

Modified:
4 years, 3 months ago

Reviewers:
bradnelson, binji

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

Stop using chromium_builder_tests target in NaCl SDK build The `chromium_builder_nacl_sdk` simply no longer exists in chromium and `chromium_builder_tests` is a no-op. Switch to building `chrome` directly, since that is all the SDK builder need in order to run thier tests. BUG=646185 Committed: https://chromium.googlesource.com/chromium/tools/build/+/efe426d8428a30f1dc4e307a28ad8e28b55828e4

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -26 lines)			Patch
M	masters/master.client.nacl.sdk/master.cfg	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py	View	6 chunks	+6 lines, -10 lines	0 comments	Download
M	scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multi.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/nacl/sdk.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/nacl/sdk.expected/basic.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Dependent Patchsets:

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336903003/1

4 years, 3 months ago (2016-09-13 20:19:28 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-09-13 20:23:50 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/efe426d8428a30f1dc4e...