scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py - Issue 2336903003: Stop using chromium_builder_tests target in NaCl SDK build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py

Issue 2336903003: Stop using chromium_builder_tests target in NaCl SDK build (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « masters/master.client.nacl.sdk/master.cfg ('k') | scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py

diff --git a/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py b/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py

index 63b6539ad9e374f93fed1e47de1335e1bea8d7de..c989cd14f941357e44fa0d57ddfeea000e8fc29b 100644

--- a/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py

+++ b/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py

@@ -78,8 +78,7 @@ def linux_sdk_multi_steps(api):

api.chromium.cleanup_temp()

# compile.py step

- args = ['--target', 'Release', '--compiler=goma',

- 'chromium_builder_nacl_sdk']

+ args = ['--target', 'Release', '--compiler=goma', 'chrome']

api.python("compile",

api.path["build"].join("scripts", "slave", "compile.py"),

args=args)

@@ -168,7 +167,7 @@ def mac_sdk_multi_steps(api):

# compile.py step

args = ['--target', 'Release', '--build-tool=ninja',

- '--compiler=goma-clang', '--', 'chromium_builder_nacl_sdk']

+ '--compiler=goma-clang', '--', 'chrome']

api.python("compile",

api.path["build"].join("scripts", "slave", "compile.py"),

args=args)

@@ -255,8 +254,7 @@ def windows_sdk_multi_steps(api):

api.chromium.cleanup_temp()

# compile.py step

- args = ['--target', 'Release', '--compiler=goma',

- 'chromium_builder_nacl_sdk']

+ args = ['--target', 'Release', '--compiler=goma', 'chrome']

api.python("compile",

api.path["build"].join("scripts", "slave", "compile.py"),

args=args)

@@ -318,8 +316,7 @@ def linux_sdk_multirel_steps(api):

api.chromium.cleanup_temp()

# compile.py step

- args = ['--target', 'Release', '--compiler=goma',

- 'chromium_builder_tests']

+ args = ['--target', 'Release', '--compiler=goma', 'chrome']

api.python("compile",

api.path["build"].join("scripts", "slave", "compile.py"),

args=args)

@@ -383,8 +380,7 @@ def windows_sdk_multirel_steps(api):

api.chromium.cleanup_temp()

# compile.py step

- args = ['--target', 'Release', '--compiler=goma',

- 'chromium_builder_tests',]

+ args = ['--target', 'Release', '--compiler=goma', 'chrome',]

api.python("compile",

api.path["build"].join("scripts", "slave", "compile.py"),

args=args)

@@ -448,7 +444,7 @@ def mac_sdk_multirel_steps(api):

# compile.py step

args = ['--target', 'Release', '--build-tool=ninja',

- '--compiler=goma-clang', '--', 'chromium_builder_tests']

+ '--compiler=goma-clang', '--', 'chrome']

api.python("compile",

api.path["build"].join("scripts", "slave", "compile.py"),

args=args)