chrome/browser/chromeos/login/existing_user_controller_browsertest.cc - Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/users_private/users_private_api.cc ('k') | chrome/browser/chromeos/login/login_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

diff --git a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

index 7978e5aa3f32c3498085904e1c35611fad6e8414..3d39a55cb7a8dbb87ac0a83dbe1dea8126f02363 100644

--- a/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

+++ b/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc

@@ -11,6 +11,7 @@

#include "base/command_line.h"

#include "base/location.h"

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

#include "base/memory/ref_counted.h"

#include "base/run_loop.h"

#include "chrome/browser/chrome_notification_types.h"

@@ -198,7 +199,8 @@ class ExistingUserControllerTest : public policy::DevicePolicyCrosBrowserTest {

void RegisterUser(const std::string& user_id) {

ListPrefUpdate users_pref(g_browser_process->local_state(),

"LoggedInUsers");

- users_pref->AppendIfNotPresent(new base::StringValue(user_id));

+ users_pref->AppendIfNotPresent(

+ base::MakeUnique<base::StringValue>(user_id));

}

// ExistingUserController private member accessors.