Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2336823003: Fix ScrollAnimator::hasRunningAnimation to account for the PostAnimationCleanup (Closed)

Created:
4 years, 3 months ago by ymalik
Modified:
4 years, 3 months ago
Reviewers:
skobes, jbroman
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ScrollAnimator::hasRunningAnimation to account for the PostAnimationCleanup Note that this bug was found while working on crbug.com/597479. fast/dom/vertical-scrollbar-in-rtl.html was failing a DCHECK because we would try to adjust when there was no animation. This CL also exposes RunState via runStateForTesting. BUG=597479 Committed: https://crrev.com/5172d6d95e6fc36231bf14cd970989f19d5cdcb9 Cr-Commit-Position: refs/heads/master@{#418574}

Patch Set 1 #

Patch Set 2 : comment update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -50 lines) Patch
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h View 3 chunks +48 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp View 1 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ymalik
4 years, 3 months ago (2016-09-13 17:23:00 UTC) #3
skobes
lgtm
4 years, 3 months ago (2016-09-13 19:07:11 UTC) #4
ymalik
+jbroman for Source/platform
4 years, 3 months ago (2016-09-13 19:10:45 UTC) #6
jbroman
rs lgtm
4 years, 3 months ago (2016-09-13 19:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336823003/20001
4 years, 3 months ago (2016-09-13 19:26:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/292311)
4 years, 3 months ago (2016-09-13 23:51:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336823003/20001
4 years, 3 months ago (2016-09-14 14:30:43 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 16:02:24 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 16:04:00 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5172d6d95e6fc36231bf14cd970989f19d5cdcb9
Cr-Commit-Position: refs/heads/master@{#418574}

Powered by Google App Engine
This is Rietveld 408576698