third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp - Issue 2336823003: Fix ScrollAnimator::hasRunningAnimation to account for the PostAnimationCleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

Issue 2336823003: Fix ScrollAnimator::hasRunningAnimation to account for the PostAnimationCleanup (Closed)

Patch Set: comment update Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

index 364765f85b02268e8e5f9680ddc95035ce66028b..e3bf6e0a28b62788b05c891827331ccc929b2de0 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

@@ -82,7 +82,8 @@ FloatPoint ScrollAnimator::desiredTargetPosition() const

bool ScrollAnimator::hasRunningAnimation() const

{

- return (m_animationCurve || m_runState == RunState::WaitingToSendToCompositor);

+ return m_runState != RunState::PostAnimationCleanup

+ && (m_animationCurve || m_runState == RunState::WaitingToSendToCompositor);

}

FloatSize ScrollAnimator::computeDeltaToConsume(const FloatSize& delta) const

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h » ('j') | no next file with comments »