Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2336543002: [turbofan] Solidify OSR deconstruction code a bit. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Solidify OSR deconstruction code a bit. It is invalid for OSR deconstruction to leave a graph with a node representing the OSR normal entry (and no OSR loop entry). Subsequent lowering phases will not handle {OsrNormalEntry} operators and hence will lead to serious clogging further down the pipeline. R=bmeurer@chromium.org BUG=chromium:641893 Committed: https://crrev.com/d2189c63628e55c7eee2e58b9529b7f156b89acd Cr-Commit-Position: refs/heads/master@{#39340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/compiler/osr.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Starzinger
Benedikt: PTAL. Ben: FYI.
4 years, 3 months ago (2016-09-12 10:42:00 UTC) #7
Benedikt Meurer
Awesome, thanks. That should hopefully detect the bug early. LGTM.
4 years, 3 months ago (2016-09-12 10:42:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336543002/1
4 years, 3 months ago (2016-09-12 10:44:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 10:46:12 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 10:46:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2189c63628e55c7eee2e58b9529b7f156b89acd
Cr-Commit-Position: refs/heads/master@{#39340}

Powered by Google App Engine
This is Rietveld 408576698