Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: src/compiler/osr.cc

Issue 2336543002: [turbofan] Solidify OSR deconstruction code a bit. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/osr.cc
diff --git a/src/compiler/osr.cc b/src/compiler/osr.cc
index 3ae11dac2731cfdc36a0b0000c2677a92673a5f3..6d61affe83659191a4f18060f92cd11a5eeda6b3 100644
--- a/src/compiler/osr.cc
+++ b/src/compiler/osr.cc
@@ -271,11 +271,8 @@ void OsrHelper::Deconstruct(JSGraph* jsgraph, CommonOperatorBuilder* common,
}
}
- if (osr_loop_entry == nullptr) {
- // No OSR entry found, do nothing.
- CHECK(osr_normal_entry);
- return;
- }
+ CHECK_NOT_NULL(osr_normal_entry); // Should have found the OSR normal entry.
+ CHECK_NOT_NULL(osr_loop_entry); // Should have found the OSR loop entry.
for (Node* use : osr_loop_entry->uses()) {
if (use->opcode() == IrOpcode::kLoop) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698