Replace paper-checkbox with a paper-icon-button-light

Replace paper-checkbox with a paper-icon-button-light

Here are some times until chrome://history is
pained/scrollable/interactive on my Z620 with Linux and a 1920px high
monitor (worst case for height-based optimization):

New UI: ~675ms
Old UI: ~700ms

Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b0b9fe38332b78ea9c1767619d3e8e6b96fbb76d
Cr-Commit-Position: refs/heads/master@{#418187}

[Dan Beam, 2016-09-12 17:51:17]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 17:52:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-09-12 17:59:08]

Description was changed from

==========
Replace paper-checkbox with a paper-icon-button-light

BUG=629710
R=tsergeant@chromium.org
==========

to

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

On my Z620 with Linux and a 1920px high monitor (worst case): 

New UI: ~675ms
Old UI: ~700ms

Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
==========

[Dan Beam, 2016-09-12 18:46:15]

Description was changed from

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

On my Z620 with Linux and a 1920px high monitor (worst case): 

New UI: ~675ms
Old UI: ~700ms

Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
==========

to

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

Here are some times until chrome://history is pained/scrollable/interactive
on my Z620 with Linux and a 1920px high monitor (worst case for height-based
optimization): 

New UI: ~675ms
New UI: ~675ms

Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
==========

[Dan Beam, 2016-09-12 18:46:46]

Description was changed from

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

Here are some times until chrome://history is pained/scrollable/interactive
on my Z620 with Linux and a 1920px high monitor (worst case for height-based
optimization): 

New UI: ~675ms
New UI: ~675ms

Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
==========

to

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

Here are some times until chrome://history is
pained/scrollable/interactive on my Z620 with Linux and a 1920px high
monitor (worst case for height-based optimization): 

New UI: ~675ms
ew UI: ~675ms
                                                                                
                                                   
Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
==========

[commit-bot: I haz the power, 2016-09-12 18:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:50:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-09-12 18:52:59]

Description was changed from

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

Here are some times until chrome://history is
pained/scrollable/interactive on my Z620 with Linux and a 1920px high
monitor (worst case for height-based optimization): 

New UI: ~675ms
ew UI: ~675ms
                                                                                
                                                   
Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
==========

to

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

Here are some times until chrome://history is
pained/scrollable/interactive on my Z620 with Linux and a 1920px high
monitor (worst case for height-based optimization): 

New UI: ~675ms
Old UI: ~700ms
                                                                                
                                                   
Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
==========

[tsergeant, 2016-09-12 23:24:58]

Thanks for cleaning this up!

Some notes on the failing tests:

history_list_test: references to `item.$.checkbox.checked` instead of
`item.selected`

lazy_render_test: paper-checkbox is no longer imported before this test runs.
Can either importHref it or change to another element which uses two-way binding

grouped_list_test: It's timing out with no output, frustratingly. The culprit is
probably 'items deletion in week view'.

https://codereview.chromium.org/2336503002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/2336503002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_item.html:99: transform-origin: 97%
86%;
paper-checkbox changes this transform-origin for RTL contexts. Is that necessary
here?

https://github.com/PolymerElements/paper-checkbox/blob/master/paper-checkbox....

[Dan Beam, 2016-09-13 03:43:27]

Description was changed from

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

Here are some times until chrome://history is
pained/scrollable/interactive on my Z620 with Linux and a 1920px high
monitor (worst case for height-based optimization): 

New UI: ~675ms
Old UI: ~700ms
                                                                                
                                                   
Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
==========

to

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

Here are some times until chrome://history is
pained/scrollable/interactive on my Z620 with Linux and a 1920px high
monitor (worst case for height-based optimization): 

New UI: ~675ms
Old UI: ~700ms
                                                                                
                                                   
Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-13 05:23:00]

On 2016/09/12 23:24:58, tsergeant wrote:
> Thanks for cleaning this up!

thanks for the help with the tests!

> 
> Some notes on the failing tests:
> 
> history_list_test: references to `item.$.checkbox.checked` instead of
> `item.selected`

Done.

> 
> lazy_render_test: paper-checkbox is no longer imported before this test runs.
> Can either importHref it or change to another element which uses two-way
binding

Done. (kinda interim fixy)

> 
> grouped_list_test: It's timing out with no output, frustratingly. The culprit
is
> probably 'items deletion in week view'.

Done.

https://codereview.chromium.org/2336503002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_item.html (right):

https://codereview.chromium.org/2336503002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_item.html:99: transform-origin: 97%
86%;
On 2016/09/12 23:24:57, tsergeant wrote:
> paper-checkbox changes this transform-origin for RTL contexts. Is that
necessary
> here?
> 
>
https://github.com/PolymerElements/paper-checkbox/blob/master/paper-checkbox....

I've done everything the <paper-checkbox> says! Even the stuff that contradicts
the other stuff!

[Dan Beam, 2016-09-13 05:23:06]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 05:23:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 05:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 05:31:09]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[tsergeant, 2016-09-13 05:40:08]

yay, lgtm

[Dan Beam, 2016-09-13 05:44:54]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-09-13 05:45:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 07:25:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-13 07:27:34]

Description was changed from

==========
Replace paper-checkbox with a paper-icon-button-light                           
                                                   

Here are some times until chrome://history is
pained/scrollable/interactive on my Z620 with Linux and a 1920px high
monitor (worst case for height-based optimization): 

New UI: ~675ms
Old UI: ~700ms
                                                                                
                                                   
Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Replace paper-checkbox with a paper-icon-button-light

Here are some times until chrome://history is
pained/scrollable/interactive on my Z620 with Linux and a 1920px high
monitor (worst case for height-based optimization):

New UI: ~675ms
Old UI: ~700ms

Note: the new UI (at this monitor height) before my change took about
~870ms, so this denotes a 23% improvement for very tall monitors.

BUG=629710
R=tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b0b9fe38332b78ea9c1767619d3e8e6b96fbb76d
Cr-Commit-Position: refs/heads/master@{#418187}
==========

[commit-bot: I haz the power, 2016-09-13 07:27:35]

Patchset 4 (id:??) landed as
https://crrev.com/b0b9fe38332b78ea9c1767619d3e8e6b96fbb76d
Cr-Commit-Position: refs/heads/master@{#418187}