Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2324293002: Roll performance-oriented iron-list changes (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, asanka, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, esprehn, egarciad_google.com, tsergeant, calamity
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll performance-oriented iron-list changes On Linux on my Z620: Old UI: ~700ms New UI (960px high): ~625ms New UI (1920px high): ~850ms This puts History in the realm of ship-ability, depending on user screen size. Test fix courtesy of michaelpg@ here: https://codereview.chromium.org/2331593002/ R=hcarmona@chromium.org BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/938d5431c9cbb0a6ded5f2d5fdc5a4091b3c0ab3 Cr-Commit-Position: refs/heads/master@{#417813}

Patch Set 1 #

Patch Set 2 : test fix courtesy of michaelpg@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -161 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 10 chunks +54 lines, -31 lines 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 9 chunks +41 lines, -31 lines 0 comments Download
M chrome/test/data/webui/settings/languages_page_browsertest.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js View 20 chunks +68 lines, -93 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (16 generated)
Dan Beam
4 years, 3 months ago (2016-09-10 00:00:27 UTC) #6
hcarmona
lgtm
4 years, 3 months ago (2016-09-10 00:25:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324293002/1
4 years, 3 months ago (2016-09-10 00:27:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/294100)
4 years, 3 months ago (2016-09-10 00:59:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324293002/20001
4 years, 3 months ago (2016-09-10 01:59:46 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-10 03:20:11 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 03:23:35 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/938d5431c9cbb0a6ded5f2d5fdc5a4091b3c0ab3
Cr-Commit-Position: refs/heads/master@{#417813}

Powered by Google App Engine
This is Rietveld 408576698