Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2336463003: clang build script: Clobber old Android toolchains. (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang build script: Clobber old Android toolchains. https://codereview.chromium.org/2317123004 switched the Android bits of the script to the new .py script. That script needs an explicit --force flag to clobber old Android toolchains, else it errors out with Running make_standalone_toolchain.py --api=21 --install-dir=... --stl=stlport --arch=arm64 Installation directory already exists. Use --force. Failed. if the --install-dir already exists (for example, from a previous build). BUG=644977 TBR=hans@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4fb78780cf8731e6e2e85d8215b26716c8cd1ad5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Nico
https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/ is currently sad because of this.
4 years, 3 months ago (2016-09-12 14:45:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4fb78780cf8731e6e2e85d8215b26716c8cd1ad5 Cr-Commit-Position: refs/heads/master@{#417938}
4 years, 3 months ago (2016-09-12 14:48:39 UTC) #5
Nico
4 years, 3 months ago (2016-09-12 14:49:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4fb78780cf8731e6e2e85d8215b26716c8cd1ad5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698