Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2317123004:
Roll clang 280106:280836. (Closed)
|
Created:
4 years, 3 months ago by Nico Modified:
4 years, 3 months ago Reviewers:
hans CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org, jbudorick Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 280106:280836.
New:
* win: Speculative fix for LNK1285/delete-pdb-and-rebuild
* win: Support for [] ATL-style uuid() attributes
* win: __nop intrinsic now has a definition
* win: complete codeview debug info for vptrs
Also switch to gnuwin-5, which is identical to gnuwin-4
except that it has gnuwin32's od.exe too.
Also switch to the python version of the Android NDK
"make standalone toolchain" script, since the .sh version
is deprecated and stopped working after the recent NDK
update.
BUG=644351, 644976, 644977
Committed: https://crrev.com/e9ed3eadc79673e746507158cfbdf2651961af6f
Cr-Commit-Position: refs/heads/master@{#417492}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : gnuwin #Patch Set 4 : linux #
Total comments: 1
Messages
Total messages: 20 (14 generated)
Description was changed from ========== Roll clang 280106:280836. . . . BUG= ========== to ========== Roll clang 280106:280836. BUG=644351 ==========
Description was changed from ========== Roll clang 280106:280836. BUG=644351 ========== to ========== Roll clang 280106:280836. Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. BUG=644351,644976 ==========
Description was changed from ========== Roll clang 280106:280836. Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. BUG=644351,644976 ========== to ========== Roll clang 280106:280836. Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated, and stopped working after the recent NDK update. BUG=644351,644976,644977 ==========
thakis@chromium.org changed reviewers: + hans@chromium.org
I still have to upload to goma and run regular tryjobs. If something goes wrong, I'd like to land the non-roll bits of this change anyhow. https://codereview.chromium.org/2317123004/diff/60001/tools/clang/scripts/upd... File tools/clang/scripts/update.py (left): https://codereview.chromium.org/2317123004/diff/60001/tools/clang/scripts/upd... tools/clang/scripts/update.py:765: '--install-dir="%s"' % toolchain_dir, python script has better quoting, "" no longer needed
Oh, and I built and uploaded the linux binary locally (I had to run the script to test the android change, and since I had the binary already..>)
lgtm if the bots are green Thanks for fixing the od.exe and NDK issues!
Description was changed from ========== Roll clang 280106:280836. Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated, and stopped working after the recent NDK update. BUG=644351,644976,644977 ========== to ========== Roll clang 280106:280836. Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated and stopped working after the recent NDK update. BUG=644351,644976,644977 ==========
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
The CQ bit was unchecked by thakis@chromium.org
Description was changed from ========== Roll clang 280106:280836. Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated and stopped working after the recent NDK update. BUG=644351,644976,644977 ========== to ========== Roll clang 280106:280836. New: * win: Speculative fix for LNK1285/delete-pdb-and-rebuild * win: Support for [] ATL-style uuid() attributes * win: __nop intrinsic now has a definition * win: complete codeview debug info for vptrs Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated and stopped working after the recent NDK update. BUG=644351,644976,644977 ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll clang 280106:280836. New: * win: Speculative fix for LNK1285/delete-pdb-and-rebuild * win: Support for [] ATL-style uuid() attributes * win: __nop intrinsic now has a definition * win: complete codeview debug info for vptrs Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated and stopped working after the recent NDK update. BUG=644351,644976,644977 ========== to ========== Roll clang 280106:280836. New: * win: Speculative fix for LNK1285/delete-pdb-and-rebuild * win: Support for [] ATL-style uuid() attributes * win: __nop intrinsic now has a definition * win: complete codeview debug info for vptrs Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated and stopped working after the recent NDK update. BUG=644351,644976,644977 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Roll clang 280106:280836. New: * win: Speculative fix for LNK1285/delete-pdb-and-rebuild * win: Support for [] ATL-style uuid() attributes * win: __nop intrinsic now has a definition * win: complete codeview debug info for vptrs Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated and stopped working after the recent NDK update. BUG=644351,644976,644977 ========== to ========== Roll clang 280106:280836. New: * win: Speculative fix for LNK1285/delete-pdb-and-rebuild * win: Support for [] ATL-style uuid() attributes * win: __nop intrinsic now has a definition * win: complete codeview debug info for vptrs Also switch to gnuwin-5, which is identical to gnuwin-4 except that it has gnuwin32's od.exe too. Also switch to the python version of the Android NDK "make standalone toolchain" script, since the .sh version is deprecated and stopped working after the recent NDK update. BUG=644351,644976,644977 Committed: https://crrev.com/e9ed3eadc79673e746507158cfbdf2651961af6f Cr-Commit-Position: refs/heads/master@{#417492} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e9ed3eadc79673e746507158cfbdf2651961af6f Cr-Commit-Position: refs/heads/master@{#417492} |
