Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2336323002: [M54] Freeze auto scrollbars while calculating table row height. (Closed)

Created:
4 years, 3 months ago by szager1
Modified:
4 years, 3 months ago
Reviewers:
esprehn, dgrogan
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[M54] Freeze auto scrollbars while calculating table row height. The cause of the infinite layout is that calcRowLogicalHeight forces a child layout without size overrides, which causes auto vertical scrollbars to change, which sets preferred width dirty. At the time that calcRowLogicalHeight runs, layout is clean, so auto scrollbars should already be in a stable state. Cherry-picked from https://codereview.chromium.org/2328883003 BUG=644635 TBR=dgrogan@chromium.org,esprehn@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/table/row-height-recalc-terminates.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
szager1
4 years, 3 months ago (2016-09-13 17:28:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336323002/1
4 years, 3 months ago (2016-09-13 17:28:52 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-13 17:28:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336323002/1
4 years, 3 months ago (2016-09-13 17:59:57 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 18:03:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698