Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 2328883003: Freeze auto scrollbars while calculating table row height. (Closed)

Created:
4 years, 3 months ago by szager1
Modified:
4 years, 3 months ago
Reviewers:
esprehn, dgrogan
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Freeze auto scrollbars while calculating table row height. The cause of the infinite layout is that calcRowLogicalHeight forces a child layout without size overrides, which causes auto vertical scrollbars to change, which sets preferred width dirty. At the time that calcRowLogicalHeight runs, layout is clean, so auto scrollbars should already be in a stable state. BUG=644635 R=dgrogan@chromium.org,esprehn@chromium.org Committed: https://crrev.com/172acf68063a6e6dee7b55edc3e6c19171d0bf5d Cr-Commit-Position: refs/heads/master@{#417792}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/table/row-height-recalc-terminates.html View 1 chunk +29 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
szager1
4 years, 3 months ago (2016-09-09 23:47:08 UTC) #1
esprehn
lgtm https://codereview.chromium.org/2328883003/diff/1/third_party/WebKit/LayoutTests/fast/table/row-height-recalc-terminates.html File third_party/WebKit/LayoutTests/fast/table/row-height-recalc-terminates.html (right): https://codereview.chromium.org/2328883003/diff/1/third_party/WebKit/LayoutTests/fast/table/row-height-recalc-terminates.html#newcode17 third_party/WebKit/LayoutTests/fast/table/row-height-recalc-terminates.html:17: <img src="xxx" /> / doesn't do anything
4 years, 3 months ago (2016-09-09 23:57:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328883003/1
4 years, 3 months ago (2016-09-09 23:58:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-10 01:30:18 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 01:32:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/172acf68063a6e6dee7b55edc3e6c19171d0bf5d
Cr-Commit-Position: refs/heads/master@{#417792}

Powered by Google App Engine
This is Rietveld 408576698