chrome/browser/resources/print_preview/print_header.js - Issue 233623003: Remember and restore the account last used destination is registered for.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_header.js

Issue 233623003: Remember and restore the account last used destination is registered for. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adjust PrintPreview unit test. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/data/user_info.js ('k') | chrome/browser/resources/print_preview/print_preview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/print_header.js

diff --git a/chrome/browser/resources/print_preview/print_header.js b/chrome/browser/resources/print_preview/print_header.js

index fdeea113c3d9598411e8e01f5863a090d08be497..7c0107d81c65bc344ae9de6a335763aa9cabea82 100644

--- a/chrome/browser/resources/print_preview/print_header.js

+++ b/chrome/browser/resources/print_preview/print_header.js

@@ -132,6 +132,7 @@ cr.define('print_preview', function() {

updatePrintButtonEnabledState_: function() {

this.getChildElement('button.print').disabled =

+ this.destinationStore_.selectedDestination == null ||

!this.isEnabled_ ||

!this.isPrintButtonEnabled_ ||

!this.printTicketStore_.isTicketValid();

@@ -222,14 +223,16 @@ cr.define('print_preview', function() {

* @private

onDestinationSelect_: function() {

- var isSaveLabel = this.destinationStore_.selectedDestination.id ==

- print_preview.Destination.GooglePromotedId.SAVE_AS_PDF ||

- this.destinationStore_.selectedDestination.id ==

- print_preview.Destination.GooglePromotedId.DOCS;

- this.getChildElement('button.print').textContent = isSaveLabel ?

- localStrings.getString('saveButton') :

- localStrings.getString('printButton');

- this.getChildElement('button.print').focus();

+ var isSaveLabel = this.destinationStore_.selectedDestination &&

+ (this.destinationStore_.selectedDestination.id ==

+ print_preview.Destination.GooglePromotedId.SAVE_AS_PDF ||

+ this.destinationStore_.selectedDestination.id ==

+ print_preview.Destination.GooglePromotedId.DOCS);

+ this.getChildElement('button.print').textContent =

+ localStrings.getString(isSaveLabel ? 'saveButton' : 'printButton');

+ if (this.destinationStore_.selectedDestination) {

+ this.getChildElement('button.print').focus();

+ }

/**