chrome/browser/resources/print_preview/print_preview.js - Issue 233623003: Remember and restore the account last used destination is registered for.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 233623003: Remember and restore the account last used destination is registered for. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adjust PrintPreview unit test. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/print_header.js ('k') | chrome/browser/resources/print_preview/search/destination_search.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/print_preview.js

diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js

index ee2f46dad09722b6bd83698ed5043ec376836116..712e5cc5793146c89105431c8ebc565509f92d63 100644

--- a/chrome/browser/resources/print_preview/print_preview.js

+++ b/chrome/browser/resources/print_preview/print_preview.js

@@ -785,6 +785,7 @@ cr.define('print_preview', function() {

if (e.keyCode == 13 /*enter*/ &&

!this.destinationSearch_.getIsVisible() &&

+ this.destinationStore_.selectedDestination &&

this.printTicketStore_.isTicketValid()) {

assert(this.uiState_ == PrintPreview.UiState_.READY,

'Trying to print when not in ready state: ' + this.uiState_);

@@ -899,9 +900,10 @@ cr.define('print_preview', function() {

onDestinationSelect_: function() {

var selectedDest = this.destinationStore_.selectedDestination;

- setIsVisible($('cloud-print-dialog-link'),

- !cr.isChromeOS && !selectedDest.isLocal);

- if (this.isInKioskAutoPrintMode_) {

+ setIsVisible(

+ $('cloud-print-dialog-link'),

+ selectedDest && !cr.isChromeOS && !selectedDest.isLocal);

+ if (selectedDest && this.isInKioskAutoPrintMode_) {

this.onPrintButtonClick_();

}