Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view.cc

Issue 233623002: Shows the info bubble when the location bar icon is clicked in the origin chip. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Comment tweaks. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view.cc b/chrome/browser/ui/omnibox/omnibox_view.cc
index ecd98b3a5207965cd4b46be5682f9af67bd7e528..de654e2d7d1d81fe8b20ecdc5442d3957d4bc13f 100644
--- a/chrome/browser/ui/omnibox/omnibox_view.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view.cc
@@ -92,7 +92,8 @@ void OmniboxView::HandleOriginChipMouseRelease() {
// Omnibox (e.g. search terms).
if ((chrome::GetOriginChipV2HideTrigger() ==
chrome::ORIGIN_CHIP_V2_HIDE_ON_MOUSE_RELEASE) &&
- controller()->GetToolbarModel()->GetText().empty()) {
+ controller()->GetToolbarModel()->GetText().empty() &&
+ !model()->focused_via_location_icon()) {
groby-ooo-7-16 2014/04/10 21:26:09 This feels very fragile - would it make more sense
macourteau 2014/04/28 19:19:24 Would the bubble already be showing by the time we
groby-ooo-7-16 2014/04/30 21:55:39 I think if you don't invoke HandleOriginChipMouseR
groby-ooo-7-16 2014/04/30 21:55:39 Keeping location icon behavior the same if there's
macourteau 2014/05/01 19:04:48 Yep, fixed.
controller()->HideOriginChip();
}
}

Powered by Google App Engine
This is Rietveld 408576698